From 7eb4f48500d14d9ebde0374b239944cb9da9da56 Mon Sep 17 00:00:00 2001 From: Kant Date: Mon, 23 Sep 2024 09:50:37 +0200 Subject: [PATCH] fix(wallet-api): open any deep-link from the webview on LLM Needed for wallet-connect-live-app deep-link back to mobile dApps --- .changeset/tough-terms-film.md | 7 +++++++ .../components/Web3AppWebview/PlatformAPIWebview.tsx | 10 +++------- .../src/components/Web3AppWebview/helpers.ts | 10 +++------- 3 files changed, 13 insertions(+), 14 deletions(-) create mode 100644 .changeset/tough-terms-film.md diff --git a/.changeset/tough-terms-film.md b/.changeset/tough-terms-film.md new file mode 100644 index 000000000000..ce11edd712fb --- /dev/null +++ b/.changeset/tough-terms-film.md @@ -0,0 +1,7 @@ +--- +"live-mobile": patch +--- + +fix(wallet-api): open any deep-link from the webview on LLM + +Needed for wallet-connect-live-app deep-link back to mobile dApps diff --git a/apps/ledger-live-mobile/src/components/Web3AppWebview/PlatformAPIWebview.tsx b/apps/ledger-live-mobile/src/components/Web3AppWebview/PlatformAPIWebview.tsx index 4888645316c4..e842ff25ddfa 100644 --- a/apps/ledger-live-mobile/src/components/Web3AppWebview/PlatformAPIWebview.tsx +++ b/apps/ledger-live-mobile/src/components/Web3AppWebview/PlatformAPIWebview.tsx @@ -507,13 +507,9 @@ export const PlatformAPIWebview = forwardRef( const onOpenWindow = useCallback((event: WebViewOpenWindowEvent) => { const { targetUrl } = event.nativeEvent; - Linking.canOpenURL(targetUrl).then(supported => { - if (supported) { - Linking.openURL(targetUrl); - } else { - console.error(`Don't know how to open URI: ${targetUrl}`); - } - }); + // Don't use canOpenURL as we cannot check unknown apps on the phone + // Without listing everything in plist and android manifest + Linking.openURL(targetUrl); }, []); useEffect(() => { diff --git a/apps/ledger-live-mobile/src/components/Web3AppWebview/helpers.ts b/apps/ledger-live-mobile/src/components/Web3AppWebview/helpers.ts index 3b32d4aa8eab..2b87b8a7dd0f 100644 --- a/apps/ledger-live-mobile/src/components/Web3AppWebview/helpers.ts +++ b/apps/ledger-live-mobile/src/components/Web3AppWebview/helpers.ts @@ -163,13 +163,9 @@ export function useWebView( const onOpenWindow = useCallback((event: WebViewOpenWindowEvent) => { const { targetUrl } = event.nativeEvent; - Linking.canOpenURL(targetUrl).then(supported => { - if (supported) { - Linking.openURL(targetUrl); - } else { - console.error(`Don't know how to open URI: ${targetUrl}`); - } - }); + // Don't use canOpenURL as we cannot check unknown apps on the phone + // Without listing everything in plist and android manifest + Linking.openURL(targetUrl); }, []); return {