From c4f09fee6c723142eafd460cc5f2eb238081e25c Mon Sep 17 00:00:00 2001 From: Benjamin Haramboure Date: Mon, 30 Sep 2024 14:05:43 +0200 Subject: [PATCH 1/3] swap most common currencies with speculos --- .github/pull_request_template.md | 4 +- .../ledger-live-desktop/tests/enum/Account.ts | 5 + .../tests/enum/AccountType.ts | 4 + apps/ledger-live-desktop/tests/enum/Swap.ts | 9 +- apps/ledger-live-desktop/tests/models/Swap.ts | 5 + .../tests/page/speculos.page.ts | 44 ++++++-- .../tests/page/swap.page.ts | 38 +++++-- .../confirmed-swap-darwin.png | Bin 0 -> 37486 bytes .../custom-fee-set-for-swap-darwin.png | Bin 0 -> 93359 bytes .../initiate-swap-darwin.png | Bin 0 -> 49707 bytes .../max-spendable-swap-darwin.png | Bin 0 -> 92736 bytes .../network-fees-drawer-darwin.png | Bin 0 -> 64336 bytes .../open-swap-page-darwin.png | Bin 0 -> 44249 bytes .../standard-network-selected-darwin.png | Bin 0 -> 57672 bytes .../target-account-drawer-darwin.png | Bin 0 -> 16351 bytes .../verify-swap-history-darwin.png | Bin 0 -> 58617 bytes .../tests/specs/speculos/swap.spec.ts | 102 ++++++++++++++---- libs/ledger-live-common/src/e2e/speculos.ts | 20 +++- libs/speculos-transport/src/index.ts | 1 + 19 files changed, 183 insertions(+), 49 deletions(-) create mode 100644 apps/ledger-live-desktop/tests/enum/AccountType.ts create mode 100644 apps/ledger-live-desktop/tests/specs/services/swap.spec.ts-snapshots/confirmed-swap-darwin.png create mode 100644 apps/ledger-live-desktop/tests/specs/services/swap.spec.ts-snapshots/custom-fee-set-for-swap-darwin.png create mode 100644 apps/ledger-live-desktop/tests/specs/services/swap.spec.ts-snapshots/initiate-swap-darwin.png create mode 100644 apps/ledger-live-desktop/tests/specs/services/swap.spec.ts-snapshots/max-spendable-swap-darwin.png create mode 100644 apps/ledger-live-desktop/tests/specs/services/swap.spec.ts-snapshots/network-fees-drawer-darwin.png create mode 100644 apps/ledger-live-desktop/tests/specs/services/swap.spec.ts-snapshots/open-swap-page-darwin.png create mode 100644 apps/ledger-live-desktop/tests/specs/services/swap.spec.ts-snapshots/standard-network-selected-darwin.png create mode 100644 apps/ledger-live-desktop/tests/specs/services/swap.spec.ts-snapshots/target-account-drawer-darwin.png create mode 100644 apps/ledger-live-desktop/tests/specs/services/swap.spec.ts-snapshots/verify-swap-history-darwin.png diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 46fd9fc4109f..b30fa8d93c0b 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -8,7 +8,7 @@ Please make sure to read CONTRIBUTING.md if you have not already. Pull Requests - [ ] `npx changeset` was attached. -- [ ] **Covered by automatic tests.** +- [ ] **Covered by automatic tests.** - [ ] **Impact of the changes:** - ... @@ -16,7 +16,7 @@ Please make sure to read CONTRIBUTING.md if you have not already. Pull Requests _Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing._ _For libraries, you can add a code sample of how to use it._ -_For bugfixes, you can explain the previous behavior and how it was fixed._ +_For bug fixes, you can explain the previous behaviour and how it was fixed._ _In case of visual features, please attach screenshots or video recordings to demonstrate the changes._