Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash with new version of EnderIO: NoClassDefFoundError: crazypants/enderio/base/machine/base/te/AbstractMachineEntity #13

Closed
aaronhowser1 opened this issue Oct 12, 2020 · 21 comments

Comments

@aaronhowser1
Copy link

Technically a duplicate of #12, but this time with more than 0 details.

Here is the crash report, the latest.log, and the debug.log.

From SleepyTrousers/EnderIO-1.5-1.12/issues/5455 and SleepyTrousers/EnderIO-1.5-1.12/issues/5443:
image

Using 1.12 minecraft, 14.23.5.2847 forge, and TickCentral-2.6.

@LeonPhilips
Copy link
Owner

LeonPhilips commented Oct 12, 2020

Try setting the TickCentral config:

SHOW_FORCED_LOADING = true
DEBUG = true

Note that this will take a long time. After the server boots up (or crashes), would you mind zipping and sending the contents of the DEBUG folder that is generated next to the TickCentral config?

I really don't have the time to diagnose this issue, but I will try and squeeze it in there...

@aaronhowser1
Copy link
Author

DEBUG.zip
There you go

@LeonPhilips
Copy link
Owner

Awesome thanks!

@LeonPhilips
Copy link
Owner

Sorry, I keep coming back to the same conclusion...
image

That zip file contains all the files that have been modified, and crazypants/enderio/base/machine/base/te/AbstractMachineEntity is not one them... However It's superclass is TileEntityEio and it's superclass is TileEntityBase

TileEntityBase has been modified. But I checked it's code and it's update method is tagged with.... final. The only reason I can think of is that this keyword is messing with us. I can try stripping that out, would you mind testing that for me?

@aaronhowser1
Copy link
Author

How would I do that?

LeonPhilips pushed a commit that referenced this issue Oct 12, 2020
@LeonPhilips
Copy link
Owner

Can you give this one a go?
Make sure the config values are set to TRUE, and I'd like another zip of that directory. If you would do that for me that'd be awesome!

Make sure to unzip TickCentral-3.1.zip. The .jar is inside of it.

@aaronhowser1
Copy link
Author

DEBUG.zip
Still crashed
image
https://pastebin.com/cnv0L1LG

@LeonPhilips
Copy link
Owner

Crap... Time to set-up a development environment again... This can take a while. Thanks for testing, I'll take it from here.

@aaronhowser1
Copy link
Author

No problem, thanks for the quick responses

LeonPhilips pushed a commit that referenced this issue Oct 12, 2020
@LeonPhilips
Copy link
Owner

As suspected, it was indeed the final flag being added.
I'm clearing that flag since the only thing it adds is compile-time checks. It just happens to trigger the run-time checker too, which stops loading of that class. I'll push a version soon.

@aaronhowser1
Copy link
Author

Awesome, thank you so much!

HenryLoenwind added a commit to SleepyTrousers/EnderIO-1.5-1.12 that referenced this issue Oct 12, 2020
@LeonPhilips
Copy link
Owner

LeonPhilips commented Oct 12, 2020

The patch I applied works, but I don't see EnderIO machines ticking... All normal minecraft behaviour works but I don't know why EnderIO no longer updates the blocks.

I have ran out of time to diagnose this issue, so I can't fix it this week/month... Here's a preview of v3.1, which has the bug I was trying to fix.

I will not upload this to curse yet, since it contains that bug. Sorry to disappoint, I might need maintainers to keep this mod going...

@HenryLoenwind
Copy link

I think that could be on our side (afterall we changed something that suddenly made your asm not work anymore). Let me test the 3.1 and if it works with my dev then I'll release.

@LeonPhilips
Copy link
Owner

Apologies! My last .jar was broken since I was still diagnosing that issue. Here's the latest one that matches 9c90ced
TickCentral-3.1_unzip_me.zip

@aaronhowser1
Copy link
Author

I don't suppose there's any update to this, either of you?

@Honsal
Copy link

Honsal commented Oct 21, 2020

Apologies! My last .jar was broken since I was still diagnosing that issue. Here's the latest one that matches 9c90ced
TickCentral-3.1_unzip_me.zip

Hey. I had exactly same problem in this issue, but this works very well. At least on client.

I will test on server and write comment of success or not.

@Honsal
Copy link

Honsal commented Oct 21, 2020

I tested in server too. On server enderio machines are not ticking as you said.

I also tested in single-player world, result was same.

EnderIO machines doesn't ticking - so no accept RF, even Vacuum blocks not catch items or XP.

but other mods - cofh, draconicevolution, industrialforegoing, darkutils, ... are perfectly working.

@HenryLoenwind
Copy link

yes, I found the reason for the "not ticking". Our machines disable ticking when they detect that nothing is being done in the tick. That is needed because we can not tell Forge on a "per TE and Side" level if we need ticking. However, this now kicks in with Tickcentral's modification of our tick.

Next Ender IO release will work again, for now I recommend disabling TickCentral. Release will come in the next 7-10 days, I just need to finish and test a rewrite I'm halfway through.

@aaronhowser1
Copy link
Author

🥺

@LeonPhilips
Copy link
Owner

Did anyone notice weird behavior with 9c90ced (TickCentral-3.1_unzip_me.zip)? If not, I can update the curseforge page

@aaronhowser1
Copy link
Author

The update causes #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants