Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Embeds away if the non-embeds are already queried #4

Open
CryZe opened this issue Jun 25, 2015 · 1 comment
Open

Optimize Embeds away if the non-embeds are already queried #4

CryZe opened this issue Jun 25, 2015 · 1 comment
Labels
enhancement

Comments

@CryZe
Copy link
Contributor

CryZe commented Jun 25, 2015

Embeds seem to be useful as they reduce the amount of API calls needed, but at the same time, they can cause issues with the current Caching implementation, as the elements might already be queried, but the embedded API call has not been done yet. So it causes more queries instead of less queries.

Simply stripping the ?embeds=... from the URL when comparing, doesn't work, because the embedded objects might not be queried yet. If there's more than 1 embedded object that it wants to access, it would cause more queries then. So this isn't really a good solution.
@CryZe
Copy link
Contributor Author

CryZe commented Jul 7, 2015

I think it should only support the opposite. Using the embedded queries for non-embedded queries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CryZe