Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant RUSTFLAGS in release.yml? #23

Open
suryyyansh opened this issue Sep 5, 2024 · 4 comments
Open

Redundant RUSTFLAGS in release.yml? #23

suryyyansh opened this issue Sep 5, 2024 · 4 comments

Comments

@suryyyansh
Copy link
Contributor

Are the RUSTFLAGS in release.yml still required after the addition of the .cargo folder?

@suryyyansh
Copy link
Contributor Author

@apepkuss Could I get an update for this. Thanks.

@apepkuss
Copy link
Collaborator

Sorry for the late reply! Please do not update the release workflow, in case there is any bad effect on the releases. For the potential issue you mentioned above, we'll check it and update the workflow if necessary. Thanks a lot!

@suryyyansh
Copy link
Contributor Author

I understand, but wouldn't it make sense to have an additional release asset for the search enabled rag-api-server? since it requires recompilation with the search feature to be used.

This is what I was going to include in my PR. Let me know what you think.

@juntao
Copy link
Collaborator

juntao commented Sep 14, 2024

Yes. I agree that we need release assets for the search-api-server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants