Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Warnings #1

Closed
LordNyriox opened this issue Feb 1, 2019 · 4 comments
Closed

Build Warnings #1

LordNyriox opened this issue Feb 1, 2019 · 4 comments
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@LordNyriox
Copy link
Owner

LordNyriox commented Feb 1, 2019

Attempting to build TLDatLexer in x64 against the current Notepad++ version results in a series of warnings.

Perhaps I could get some help cleaning these up?

c:\projects\tldatlexer\tldatlexer\lexer.cpp(284):	warning C4244:	'initializing':	conversion from 'sptr_t' to 'unsigned int',	possible loss of data
c:\projects\tldatlexer\tldatlexer\lexer.cpp(290):	warning C4244:	'initializing':	conversion from 'sptr_t' to 'unsigned int',	possible loss of data
c:\projects\tldatlexer\tldatlexer\lexer.cpp(361):	warning C4244:	'initializing':	conversion from 'sptr_t' to 'int',		possible loss of data
c:\projects\tldatlexer\tldatlexer\lexer.cpp(362):	warning C4244:	'initializing':	conversion from 'sptr_t' to 'int',		possible loss of data
c:\projects\tldatlexer\tldatlexer\lexer.cpp(373):	warning C4244:	'initializing':	conversion from 'sptr_t' to 'int',		possible loss of data
c:\projects\tldatlexer\tldatlexer\lexer.cpp(412):	warning C4244:	'initializing':	conversion from 'sptr_t' to 'int',		possible loss of data
c:\projects\tldatlexer\tldatlexer\lexer.cpp(413):	warning C4244:	'initializing':	conversion from 'sptr_t' to 'int',		possible loss of data
c:\projects\tldatlexer\tldatlexer\plugin.cpp(44):	warning C4459:	declaration of 'name' hides global declaration
c:\projects\tldatlexer\tldatlexer\plugin.cpp(113):	warning C4244:	'initializing':	conversion from 'sptr_t' to 'unsigned int',	possible loss of data
c:\projects\tldatlexer\tldatlexer\plugin.cpp(131):	warning C4459:	declaration of 'name' hides global declaration
	10 Warning(s)
	0 Error(s)
@LordNyriox LordNyriox changed the title Build Warnings [x64] Build Warnings Feb 1, 2019
@LordNyriox LordNyriox changed the title [x64] Build Warnings Build Warnings (x64) Feb 1, 2019
@LordNyriox
Copy link
Owner Author

LordNyriox commented Feb 1, 2019

Attempting to build in win32 mode results in a shorter list containing two of the same warnings. These "declaration of name" warnings should probably be considered higher priority to fix.

c:\projects\tldatlexer\tldatlexer\plugin.cpp(44):	warning C4459:	declaration of 'name' hides global declaration
c:\projects\tldatlexer\tldatlexer\plugin.cpp(131):	warning C4459:	declaration of 'name' hides global declaration
	2 Warning(s)
	0 Error(s)

@LordNyriox
Copy link
Owner Author

LordNyriox commented Feb 2, 2019

[C4244] only shows up when building in x64 mode.

[C4459] shows up for for both win32 and x64 builds.

[LNK4197] is fixed, as of [PR#2].

Links for relevant "hidden" warnings:

[C4710], [C4820], [C4365], [C4571]

@LordNyriox
Copy link
Owner Author

The Scintilla types sptr_t and uptr_t are defined in [https://github.com/notepad-plus-plus/notepad-plus-plus/blob/master/scintilla/include/Scintilla.h#L29].

@LordNyriox LordNyriox added the enhancement New feature or request label May 13, 2019
@LordNyriox LordNyriox changed the title Build Warnings (x64) Build Warnings May 13, 2019
@LordNyriox
Copy link
Owner Author

With notepad-plus-plus upgrading to Scintilla v4.1.4, TLDatLexer now has much bigger problems than a few relatively minor warnings.

Closing this issue in favor of [Issue #8].

@LordNyriox LordNyriox added the wontfix This will not be worked on label May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant