Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to change device state json doc capacity #23

Open
tedbyron opened this issue Jun 12, 2023 · 1 comment
Open

No way to change device state json doc capacity #23

tedbyron opened this issue Jun 12, 2023 · 1 comment

Comments

@tedbyron
Copy link

It looks like MQTT_MAX_PACKET_SIZE is being used as the MQTT client buffer size but not the state JSON doc size, why is that? Because the document size is so limited, when device state is too large it will just serialize to null. Increasing MQTT_MAX_PACKET_SIZE doesn't fix this as stated in the readme, because it doesn't change the doc size

@InconceivableDuck
Copy link
Member

Hey @tedbyron! I believe this is an unexpected behavior change when we migrated from ArduinoJson v5 to v6. Whereas before this size only need to be large enough to include the wrapper, it appears as though it now may be copying the incoming state instead of supporting the pointer. Good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants