-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeError: manager.getActions is not a function with latest react-dnd version (9.3.2 at time of writing) #31
Comments
@chuckdries Thanks for the report, I will take a look as soon as possible! |
Just to keep you up to date, I am preparing a new version (probably 4.0.0) on the However react-dnd non-esm builds are completely broken (wrong entry point, wrong imports...) so it will have to wait until that is fixed. In the meantime, I will update |
Hasn't import been fixed in the https://github.com/react-dnd/react-dnd/releases/tag/v9.3.3 :) |
@vkuba This issue also needs to be solved react-dnd/react-dnd#1468 |
@LouisBrunner, how's it going ? :) |
@san4oz I have been continuing work on the
I can't seem to pinpoint the problem, so if any of you would like to take a look and contribute a fix or just advise on a course of action, that would be great! |
Did you found the error? In general, this error is pretty clear. I read the code in next branch, I do not see any invalid hook call. Is it possible you have two versions of React installed? |
Maybe don't use hooks for now? |
Thanks Louis for all your hard work! I just hit the Would you happen to know the maximum release--of all related packages--one should use that still supports the awesome After rolling back: I think this will be good information for all the fans to know! All the best and many thanks for your relentless toil! |
@babalugats76 Thank you for the really high praise! :) From what I can see, I just pushed a new version under the |
Thanks Louis! I did try to "next" the module and update all of the dependencies via npm (I am using
I believe this is related to 1468? Not quite sure how to work around this :/ |
The |
Thank you so much. I did give it a shot. Here are my modules:
Here are my imports:
Here is my custom pipeline:
In my render, I am using the
Unfortunately, I am still getting the TypeError: Knowing me, this is probably user error :) I am using the custom pipeline in order to set |
I completely forgot to link that, my bad: https://github.com/LouisBrunner/dnd-multi-backend/tree/next/packages/react-dnd-multi-backend#migrating-from-3xx
You will have to transform your pipeline from
to
|
Boom! Thank you; I appreciate that. The additional migration note is helpful and clear! Adjusted custom pipeline to:
Adjusted
All preliminary tests are passing, but I will keep at it. Many thanks! |
Hi, EDIT: nevermind that was some npm bug, I just restarted it and it works perfectly.I had the same problem, so I installed all the dependencies :
used the same import and custom pipeline as above but with Then this error appeared :
Could you help me understand why ? |
As it seems like this issue is now fixed by |
Awesome! So just for clarification's sake, do we still need all the CommonJS stuff? Are there still plans in the works apropos that? Thanks again for all the hard work. |
@babalugats76 v4 will work with CommonJS |
Reproduction: https://codesandbox.io/s/react-dnd-example-11-ow923
Potentially related to the removal of
DragDropContext
(replaced by DndProvider)The text was updated successfully, but these errors were encountered: