Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated regression testing #86

Open
katlogic opened this issue Oct 1, 2015 · 7 comments
Open

Automated regression testing #86

katlogic opened this issue Oct 1, 2015 · 7 comments

Comments

@katlogic
Copy link

katlogic commented Oct 1, 2015

Currently, hacking on LuaJIT code is difficult because there seems to be no way to test it.

Some thoughts:

Other ideas?

@DemiMarie
Copy link

What are some of the ways in which LuaJIT deviates from Lua?

@refi64
Copy link

refi64 commented Oct 15, 2015

Wasn't @MikePall going to clean up his test suite and upload it online?

@pmatos
Copy link

pmatos commented Oct 15, 2015

Truthfully, if @MikePall has no time to clean it up, it might be better to provide it in 'raw' form such that somehow might clean it up than to have nothing at all.

I am new to LuaJIT but I am certainly surprised that such a successful project has survived so long without a proper regression suite.

@refi64
Copy link

refi64 commented Oct 15, 2015

@pmatos It has a regression suite. We just can't see it. :)

@katlogic
Copy link
Author

@drbo: From top of my head:

  • error()s thrown messages format and wording in a lot of places
  • Underdefined/underspecified behavior, especially regarding gc. Lua test suite makes assumption that gc will trigger eventually because of repeated allocations, this is not true in LuaJIT
  • Straight bugs triggered by the test suite, such as function x() coroutine.wrap(x)() end x()

@agladysh
Copy link

NB: This can be used as test suite as well: https://github.com/fperrad/lua-TestMore/tree/master/test_lua51

@katlogic
Copy link
Author

@agladysh This looks pretty good, thanks!

akopytov pushed a commit to akopytov/LuaJIT that referenced this issue Oct 15, 2016
fperrad pushed a commit to fperrad/LuaJIT that referenced this issue Jan 26, 2020
Resolves LuaJIT#86.

Signed-off-by: Siddhesh Poyarekar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants