From c15694ba8bf908a45f5d96b3d6972aa70b6315e0 Mon Sep 17 00:00:00 2001 From: Sally Young Date: Wed, 13 Dec 2023 12:43:38 +0000 Subject: [PATCH] Remove tests for old Selenium and PHP versions --- .github/workflows/tests.yml | 11 +++-------- phpunit.xml.dist | 2 +- tests/Selenium2Config.php | 2 +- 3 files changed, 5 insertions(+), 10 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 2205b40f..822f31e2 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -43,8 +43,8 @@ jobs: runs-on: ubuntu-20.04 strategy: matrix: - php: [ '7.2', '7.3', '7.4', '8.0', '8.1' ] - selenium: ['2.53.1', 'latest'] + php: [ '8.1', '8.2', '8.3' ] + selenium: ['latest'] fail-fast: false steps: @@ -81,12 +81,7 @@ jobs: while ! nc -z localhost 8002 --> - + diff --git a/tests/Selenium2Config.php b/tests/Selenium2Config.php index 109ebc58..e0a24bf3 100644 --- a/tests/Selenium2Config.php +++ b/tests/Selenium2Config.php @@ -18,7 +18,7 @@ public static function getInstance(): self public function createDriver(): DriverInterface { $browser = getenv('WEB_FIXTURES_BROWSER') ?: 'firefox'; - $seleniumHost = !empty(getenv('DRIVER_URL')) ? getenv('DRIVER_URL') : 'http://localhost:4444/wd/hub'; + $seleniumHost = !empty(getenv('DRIVER_URL')) ? getenv('DRIVER_URL') : '"http://localhost:4444'; return new Selenium2Driver($browser, null, $seleniumHost); }