From 1abf48e73564b917efff08eae85b9aee83f17ade Mon Sep 17 00:00:00 2001 From: Alex Pott Date: Wed, 17 Jul 2024 10:32:27 +0100 Subject: [PATCH 1/2] Remove DRIVER_URL setting --- .github/workflows/tests.yml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 5318b1db..9cff2ece 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -91,11 +91,7 @@ jobs: - name: Run tests run: | - if [ "${{ matrix.selenium }}" == "latest" ] || [ "${{ matrix.selenium }}" == "4.1.2" ]; then - ./vendor/bin/phpunit -v --coverage-clover=coverage.xml - else - DRIVER_URL="http://localhost:4444/wd/hub" ./vendor/bin/phpunit -v --coverage-clover=coverage.xml - fi + ./vendor/bin/phpunit -v --coverage-clover=coverage.xml - name: Upload coverage uses: codecov/codecov-action@v2 From 2432456cdab92f3efe35cf64eb59f1fdb9966822 Mon Sep 17 00:00:00 2001 From: Alex Pott Date: Wed, 17 Jul 2024 10:34:36 +0100 Subject: [PATCH 2/2] Drop selenium 2 and 3 testing --- .github/workflows/tests.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 9cff2ece..f863f93b 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -50,10 +50,8 @@ jobs: strategy: matrix: php: [ '8.1', '8.2', '8.3' ] - # 2.53.1 - version the original package was using for tests - # 3 - last version of 3 # 4.1.2-20220227 - last known working version of 4 where the modifications to this package weren't needed - selenium: ['2.53.1', '3', '4.1.2', 'latest'] + selenium: ['4.1.2', 'latest'] fail-fast: false steps: