From 589f5000feda59c8f231ce7b3ef55376f0ceb83e Mon Sep 17 00:00:00 2001 From: Alex Pott Date: Wed, 3 Jul 2024 22:58:41 +0100 Subject: [PATCH 1/3] Fix PHP version testing --- .github/workflows/Tests.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/Tests.yml b/.github/workflows/Tests.yml index 9503048..0983553 100644 --- a/.github/workflows/Tests.yml +++ b/.github/workflows/Tests.yml @@ -24,10 +24,15 @@ jobs: - uses: actions/checkout@v3 - uses: ddev/github-action-setup-ddev@v1 + with: + autostart: false - name: Setup PHP Version run: ddev config --php-version ${{ matrix.php }} + - name: Start ddev + run: ddev start + - name: Install dependencies run: ddev composer install From 6f6ada259de1c68970c3a6611b87869675547ce0 Mon Sep 17 00:00:00 2001 From: Alex Pott Date: Wed, 3 Jul 2024 23:02:52 +0100 Subject: [PATCH 2/3] More honest PHP version testing --- .github/workflows/Tests.yml | 2 +- composer.json | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/Tests.yml b/.github/workflows/Tests.yml index 0983553..203cdd1 100644 --- a/.github/workflows/Tests.yml +++ b/.github/workflows/Tests.yml @@ -17,7 +17,7 @@ jobs: strategy: matrix: - php: [ '7.4', '8.0', '8.1', '8.2' ] + php: [ '8.0', '8.3' ] fail-fast: false steps: diff --git a/composer.json b/composer.json index 9ad0551..e959545 100644 --- a/composer.json +++ b/composer.json @@ -11,7 +11,8 @@ "homepage": "https://www.lullabot.com/", "license": "Apache-2.0", "require": { - "ext-curl": "*" + "ext-curl": "*", + "php": ">=8.0.0" }, "require-dev": { "phpunit/phpunit": "^8.5 || ^9.5" From e0ad52e33ff967a19bdc87398a2c796c3477bbd1 Mon Sep 17 00:00:00 2001 From: Alex Pott Date: Wed, 3 Jul 2024 23:12:29 +0100 Subject: [PATCH 3/3] Fix some PHP 8.3 issues in tests --- test/Test/WebDriver/ChromeDriverTest.php | 1 + test/Test/WebDriver/GeckoDriverTest.php | 1 + 2 files changed, 2 insertions(+) diff --git a/test/Test/WebDriver/ChromeDriverTest.php b/test/Test/WebDriver/ChromeDriverTest.php index bb2e074..fde5d64 100644 --- a/test/Test/WebDriver/ChromeDriverTest.php +++ b/test/Test/WebDriver/ChromeDriverTest.php @@ -37,6 +37,7 @@ class ChromeDriverTest extends WebDriverTestBase { protected $testWebDriverRootUrl = 'http://localhost:9515'; protected $testWebDriverName = 'chromedriver'; + protected $status = null; protected function setUp(): void { diff --git a/test/Test/WebDriver/GeckoDriverTest.php b/test/Test/WebDriver/GeckoDriverTest.php index 1397cef..d0e9c47 100644 --- a/test/Test/WebDriver/GeckoDriverTest.php +++ b/test/Test/WebDriver/GeckoDriverTest.php @@ -37,6 +37,7 @@ class GeckoDriverTest extends WebDriverTestBase { protected $testWebDriverRootUrl = 'http://localhost:4444'; protected $testWebDriverName = 'geckodriver'; + protected $status = null; protected function setUp(): void {