Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Python game engine #50

Open
1 of 5 tasks
alesolano opened this issue Oct 26, 2021 · 2 comments
Open
1 of 5 tasks

Test Python game engine #50

alesolano opened this issue Oct 26, 2021 · 2 comments
Assignees
Labels
not-agent Here we don't affect the agent perse

Comments

@alesolano
Copy link
Member

alesolano commented Oct 26, 2021

Description

@chucheria shared this new game engine that claims to be 45x faster than the one we are using. That's a huge statement. Let's test it.

Requirements

Things you need in order to complete the issue.

Acceptance Criteria

Criteria that must be met in order to close the issue successfully.

  • train.py is executed successfully with the new import
  • time measurement of the new train.py execution along 10 episodes.
  • time measurement of the old train.py execution along 10 episodes.
@alesolano alesolano added the not-agent Here we don't affect the agent perse label Oct 26, 2021
@alesolano alesolano self-assigned this Oct 26, 2021
@alesolano
Copy link
Member Author

alesolano commented Oct 26, 2021

Lots of problems with the installation. I've left an open issue in the repo: glmcdona/LuxPythonEnvGym#107

EDIT: SOLVED!

@alesolano
Copy link
Member Author

OK, things are more complicated than I thought.

Their game.py is very different than the standard game.py. Our code breaks since, for example, _initialize(), _update() or players are not methods/attributes of the class Game.

@chucheria @DelgadoPanadero can you take a look at the difference between those two game.py files? Do you see a way that we can easily use their engine without changing too much of our code? Is it worth it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-agent Here we don't affect the agent perse
Projects
None yet
Development

No branches or pull requests

1 participant