We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GetReader
namespace OmniReader { Reader *GetReader(OmniReader::Format option) { switch (option) { case OmniReader::Format::PlainText: return new PlainTextReader(); case OmniReader::Format::BZ2: return new BZ2Reader(); case OmniReader::Format::GZ: return new GZReader(); default: return nullptr;
Has a high chance of leaking memory due to using a raw pointer for the reader. We should use a std::shared_ptr<XReader> or ``std::unique_ptr` instead.
std::shared_ptr<XReader>
The text was updated successfully, but these errors were encountered:
I've never actually used fancy pointers.... If you do a PR and it doesn't nudge perf then sure
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
Has a high chance of leaking memory due to using a raw pointer for the reader. We should use a
std::shared_ptr<XReader>
or ``std::unique_ptr` instead.
The text was updated successfully, but these errors were encountered: