Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement streaming for data downloads #302

Open
WardLT opened this issue Feb 16, 2023 · 2 comments
Open

Implement streaming for data downloads #302

WardLT opened this issue Feb 16, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@WardLT
Copy link
Collaborator

WardLT commented Feb 16, 2023

Our present implementation for data downloads reads the entire file into memory before writing.
You can avoid that by reading in chunks: https://stackoverflow.com/questions/16694907/download-large-file-in-python-with-requests

See:

foundry/foundry/https_download.py

Line 70 in 092fe73

response = requests.get(url)

@ascourtas
Copy link
Contributor

how high priority is this, would we say?

@WardLT
Copy link
Collaborator Author

WardLT commented Jun 14, 2023

No one has complained yet, so I don't think it's high priority.

@kjschmidt913 kjschmidt913 added the enhancement New feature or request label Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@WardLT @kjschmidt913 @ascourtas