Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static code analysis (MRCpp) #191

Open
susilehtola opened this issue Dec 30, 2021 · 1 comment
Open

Static code analysis (MRCpp) #191

susilehtola opened this issue Dec 30, 2021 · 1 comment

Comments

@susilehtola
Copy link
Contributor

compiling mrcpp yields some compiler warnings in Fedora 35. The most common issue appears to be the comparison between signed and unsigned which arises from the use of int as loop indices checked against .size() which returns the size type, size_t. The loop indices could probably be all switched to size_t, what do you think?

Additionally, running static code analysis on the repository yields unclean results; output from cppcheck 2.6 attached
cppcheck.log
.

@susilehtola susilehtola changed the title Static code analysis Static code analysis (MRCpp) Dec 30, 2021
@stigrj
Copy link
Contributor

stigrj commented Jan 1, 2022

Thanks for reporting, I will have a go at this next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants