Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: PolyFuzz don't take a model_id #74

Open
raffaem opened this issue Dec 6, 2023 · 1 comment
Open

Documentation: PolyFuzz don't take a model_id #74

raffaem opened this issue Dec 6, 2023 · 1 comment

Comments

@raffaem
Copy link
Contributor

raffaem commented Dec 6, 2023

In some documented examples a model_id paramater is passed to the constructor of PolyFuzz, but PolyFuzz's constructor don't take such parameter

For instance, the example here

import polyfuzz as pf
model = pf.PolyFuzz("TF-IDF", model_id="TF-IDF")

which return:

TypeError                                 Traceback (most recent call last)
Cell In[12], line 2
      1 import polyfuzz as pf
----> 2 model = pf.PolyFuzz("TF-IDF", model_id="TF-IDF")
      3 model.match(from_list = ["string_one", "string_two"],
      4             to_list = ["string_three", "string_four"])

TypeError: PolyFuzz.__init__() got an unexpected keyword argument 'model_id'
@MaartenGr
Copy link
Owner

Thanks for sharing this! It sees to be old documentation. I'll make sure it gets updated in a new release unless someone else comes around to pick this up including some of the other documentation updates you shared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants