Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failing on Ember 2.12 #14

Open
laantorchaweb opened this issue Apr 21, 2017 · 5 comments
Open

Build failing on Ember 2.12 #14

laantorchaweb opened this issue Apr 21, 2017 · 5 comments

Comments

@laantorchaweb
Copy link

Maybe related to having Ember moved away from bower_components, but it's throwing this error:

Error: Cannot find module '/bower_components/ember/ember-template-compiler'
at Class.module.exports.htmlbarsOptions (/node_modules/ember-cli-sortable/node_modules/ember-cli-htmlbars/ember-addon-main.js:70:25)
@laantorchaweb
Copy link
Author

Hey, @MaazAli any ideas about how to solve this issue? If I make a PR can you merge and publish?

@ghost
Copy link

ghost commented Aug 28, 2017

having same issue
Ember version 2.14.1.
Any fix for that?

@ghost
Copy link

ghost commented Aug 28, 2017

@laantorchaweb did you find any solution plz share.

@MaazAli
Copy link
Owner

MaazAli commented Aug 29, 2017

I'm no longer maintaining this addon, it is very likely that it no longer works!

@SanthoshRaju91
Copy link

Hello,

Sorry to comment on this thread again, even though you meant that this is not longer maintained. But this addon is being used in one of our project's and by many of them as well.

So I took the privilege, in upgrading the addon to 2.12, fixing the eslint issues, and writing a small working example of the addon.

Also, I have updated the index.js file, to include _findHost hook. So this support ember-engine's application as well.

I have raised a PR. Could you please validate them and merge it.

Warm Regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants