Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of six #279

Open
matthewfeickert opened this issue Dec 3, 2024 · 0 comments
Open

Remove use of six #279

matthewfeickert opened this issue Dec 3, 2024 · 0 comments
Labels
⚙️enhancement New feature or request

Comments

@matthewfeickert
Copy link
Contributor

Feature details

MadAnalysis5 is Python 3+ only and requiring

madanalysis5/bin/ma5

Lines 50 to 56 in 3900ec9

# Checking that the 'six' package is present
if not importlib.util.find_spec("six"):
sys.exit(
'The python "six" module is not found on your system and it is required for MadAnalysis 5 for '
+ "a question of Python 2/3 compatibility. Please install it with the following command:\n"
+ "pip install six"
)

and using six

$ git grep "import six" | wc -l
32

is not needed.

Implementation

Use 2to3 and ruff (https://github.com/astral-sh/ruff).

How important would you say this feature is?

1: Not important. Would be nice to have.

Additional information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant