You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
thanks for the library - really like it! I just find the OnColorSelectionListener a bit clumsy to use from Kotlin as you cannot just pass a lambda. What do you think converting it to a SAM so we can use it this way and have nicer code?
My suggestion would be to combine onColorSelected onColorSelectionStart onColorSelectionEnd and differentiate via a parameter (e.g. an enum SELECTED,START,END)
I could also provide this as a PR - but wanted your opinion first as it is a breaking change.
The text was updated successfully, but these errors were encountered:
ligi
changed the title
OnColorSelectionListener
OnColorSelectionListener as SAM
Oct 17, 2018
@ligi Could you show a usage of this interface for a client who's overriding all the 3 methods in the interface? We want to see how it would look like at the client code.
thanks for the library - really like it! I just find the OnColorSelectionListener a bit clumsy to use from Kotlin as you cannot just pass a lambda. What do you think converting it to a SAM so we can use it this way and have nicer code?
My suggestion would be to combine onColorSelected onColorSelectionStart onColorSelectionEnd and differentiate via a parameter (e.g. an enum SELECTED,START,END)
I could also provide this as a PR - but wanted your opinion first as it is a breaking change.
The text was updated successfully, but these errors were encountered: