Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tooltip missing on repeat button #18

Open
ImaCrea opened this issue Oct 14, 2019 · 3 comments
Open

tooltip missing on repeat button #18

ImaCrea opened this issue Oct 14, 2019 · 3 comments
Labels

Comments

@ImaCrea
Copy link
Member

ImaCrea commented Oct 14, 2019

Hi there,
I've recently updated the front end to Bootstrap 4 and they changed their tooltip module. Hence, the repeat button behavior needs a quick fix to have its tooltip working again. Meanwhile, I've commented that part.

See assets/javascripts/page-player.js around line 87

@ImaCrea
Copy link
Member Author

ImaCrea commented Oct 14, 2019

Hi @augnustin would you like to update your little repeat button please? :)

@augnustin
Copy link
Contributor

Hey @ImaCrea zup? 😄

Is popover.js loaded already?

If not, it may be a pain to set it up only for that purpose.

I'd go for only setting a title, that is displayed on hover anyway:

$el.attr('title', tooltip);

If it is, then something like:

$el.popover();

right after the $el.attr('title', tooltip); line should do the trick.

@ImaCrea
Copy link
Member Author

ImaCrea commented Oct 16, 2019

Content d'avoir de tes news @augnustin :)
Ecoute, on utilise encore tooltip pour le bouton musicolor et le bouton follow. De manière générale je trouve que c'est plus propre qu'un tooltip "classique".

Donc par cohérence, il faudrait rester sur la même présentation. Par contre pas sur de comprendre là tes propositions, tu veux pas tester direct dans le code et faire un pr ? 😅

@ImaCrea ImaCrea added the bug label Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants