Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show description in modal for rhythm #14

Open
4 tasks
gregdyke opened this issue Sep 29, 2023 · 3 comments
Open
4 tasks

Show description in modal for rhythm #14

gregdyke opened this issue Sep 29, 2023 · 3 comments
Assignees

Comments

@gregdyke
Copy link
Collaborator

Story

  • As a website visitor

  • I Want to see the description of a rhythm in an unobtrusive way

  • So That I can get understanding that is not conveyed by the video

Acceptance Criteria

  1. Given the rhythm has a description only
    • When the modal for that rhythm opens
    • Then the description is visible
  2. Given the rhythm has a description and a video
    • When the modal for that rhythm opens
    • Then two tabs are visible, with the video tab selected
    • And clicking the description tab shows the description
    • And the tabs are unobtrusive (hover? tbd?) so that the solo video remains visually uncluttered

Implementation Notes

  1. Obviously, needs data on the server to be added + in api calls, etc

Checklist:

  • I have defined the user story
  • I have defined some acceptance criteria
  • I have included any implementation notes
  • I have included all relevant links
@mferryRV
Copy link
Collaborator

mferryRV commented Oct 2, 2023

Descriptions for the two data points (DC hand dancing and Rumba Guaguanco) would be helpful here.

@gregdyke
Copy link
Collaborator Author

gregdyke commented Oct 3, 2023

@mferryRV
Copy link
Collaborator

mferryRV commented Oct 4, 2023

@gregdyke - how does this fit with #15 ? If a rhythm has Audio, Video, and a Description, how many tabs should there be?

If a rhythm has only Video or only a Description, should we display one tab or no tabs at all?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants