From 7a70e804abf3dfa3f657c4e901d706ffd2e4fdef Mon Sep 17 00:00:00 2001 From: Iulian <40763147+iulian03@users.noreply.github.com> Date: Fri, 28 Feb 2025 17:09:55 +0200 Subject: [PATCH] [bugfix] added missing timeout config for doRequestList() (#356) * added missing timeout config for doRequestList() * re-enabled test --------- Co-authored-by: Iulian Masar --- src/main/java/com/mangopay/core/RestTool.java | 4 ++++ .../java/com/mangopay/core/VirtualAccountApiImplTest.java | 7 ++----- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/main/java/com/mangopay/core/RestTool.java b/src/main/java/com/mangopay/core/RestTool.java index 27551b35..cbe37680 100644 --- a/src/main/java/com/mangopay/core/RestTool.java +++ b/src/main/java/com/mangopay/core/RestTool.java @@ -589,6 +589,10 @@ private List doRequestList(Class classOfT, Class clas if (connection instanceof HttpsURLConnection) { configureSslContext((HttpsURLConnection) connection); } + // Get connection timeout from config + connection.setConnectTimeout(this.root.getConfig().getConnectTimeout()); + // Get read timeout from config + connection.setReadTimeout(this.root.getConfig().getReadTimeout()); // set request method connection.setRequestMethod(this.requestType); diff --git a/src/test/java/com/mangopay/core/VirtualAccountApiImplTest.java b/src/test/java/com/mangopay/core/VirtualAccountApiImplTest.java index 09f3c271..9601e81c 100644 --- a/src/test/java/com/mangopay/core/VirtualAccountApiImplTest.java +++ b/src/test/java/com/mangopay/core/VirtualAccountApiImplTest.java @@ -3,7 +3,6 @@ import com.mangopay.entities.VirtualAccount; import com.mangopay.entities.Wallet; import com.mangopay.entities.subentities.VirtualAccountAvailabilities; -import org.junit.Ignore; import org.junit.Test; import java.util.List; @@ -46,15 +45,13 @@ public void getAllVirtualAccounts() throws Exception { assertEquals(1, virtualAccounts.size()); } - // TODO - @Ignore("API issue. Re-enable after fix.") @Test public void getAvailabilities() throws Exception { VirtualAccountAvailabilities availabilities = this.api.getVirtualAccountApi().getAvailabilities(); assertNotNull(availabilities); - assertTrue(availabilities.getCollection().getClass().isArray()); - assertTrue(availabilities.getUserOwned().getClass().isArray()); + assertFalse(availabilities.getCollection().isEmpty()); + assertFalse(availabilities.getUserOwned().isEmpty()); } @Test