From d4ae41b318bc99721a9e8bf574969281820fe46d Mon Sep 17 00:00:00 2001 From: Iulian Masar Date: Fri, 7 Feb 2025 17:40:01 +0200 Subject: [PATCH 1/2] added extra checks --- .../java/com/mangopay/core/CardApiImplTest.java | 6 ++++++ .../com/mangopay/core/DisputeApiImplTest.java | 17 ++++++++++++++++- .../com/mangopay/core/PayInApiImplTest.java | 6 ++++++ .../java/com/mangopay/core/UserApiImplTest.java | 12 ++++++++++++ .../com/mangopay/core/WalletApiImplTest.java | 13 +++++++++++++ 5 files changed, 53 insertions(+), 1 deletion(-) diff --git a/src/test/java/com/mangopay/core/CardApiImplTest.java b/src/test/java/com/mangopay/core/CardApiImplTest.java index 4442ccac..e87504ef 100644 --- a/src/test/java/com/mangopay/core/CardApiImplTest.java +++ b/src/test/java/com/mangopay/core/CardApiImplTest.java @@ -1,6 +1,7 @@ package com.mangopay.core; import com.mangopay.core.APIs.CardApi; +import com.mangopay.core.enumerations.TransactionStatus; import com.mangopay.core.enumerations.TransactionType; import com.mangopay.entities.*; import com.mangopay.entities.subentities.PayInPaymentDetailsCard; @@ -38,6 +39,11 @@ public void getTransactions() throws Exception { assertNotNull("Card transactions came back null", transactions); assertFalse("Api returned an empty list of card transactions", transactions.isEmpty()); + + for (Transaction t : transactions) { + assertNotNull(t.getStatus()); + assertNotEquals(TransactionStatus.NotSpecified, t.getStatus()); + } } @Test diff --git a/src/test/java/com/mangopay/core/DisputeApiImplTest.java b/src/test/java/com/mangopay/core/DisputeApiImplTest.java index ace165ac..f4980625 100644 --- a/src/test/java/com/mangopay/core/DisputeApiImplTest.java +++ b/src/test/java/com/mangopay/core/DisputeApiImplTest.java @@ -30,7 +30,7 @@ /** * DisputeApiImpl test methods. */ -@Ignore("Comment this line out to allow DisputeApi unit tests run") + public class DisputeApiImplTest extends BaseTest { private List clientDisputes = null; @@ -74,6 +74,11 @@ public void getTransactions() throws Exception { assertNotNull(result); assertFalse(result.isEmpty()); + + for (Transaction t : result) { + assertNotNull(t.getStatus()); + assertNotEquals(TransactionStatus.NotSpecified, t.getStatus()); + } } @Test @@ -114,6 +119,12 @@ public void getDisputesForUser() throws Exception { assertNotNull(result); assertFalse(result.isEmpty()); + + assertFalse(transactions.isEmpty()); + for (Transaction t : transactions) { + assertNotNull(t.getStatus()); + assertNotEquals(TransactionStatus.NotSpecified, t.getStatus()); + } } @Test @@ -169,6 +180,7 @@ public void createDisputePage() throws Exception { } @Test + @Ignore("Cannot be tested. Needs manual creation of dispute on API side") public void contestDispute() throws Exception { Dispute notContestedDispute = null; @@ -211,6 +223,7 @@ public void saveTag() throws Exception { } @Test + @Ignore("Cannot be tested. Needs manual creation of dispute on API side") public void closeDispute() throws Exception { Dispute dispute = null; @@ -328,6 +341,7 @@ public void getDocumentsForClient() throws Exception { } @Test + @Ignore("Cannot be tested. Needs manual creation of dispute on API side") public void submitDisputeDocument() throws Exception { Dispute dispute = null; DisputeDocument disputeDocument = null; @@ -507,6 +521,7 @@ public void getFilteredDisputeDocuments() throws Exception { } @Test + @Ignore("Cannot be tested. Needs manual creation of dispute on API side") public void resubmitDispute() throws Exception { Dispute dispute = null; diff --git a/src/test/java/com/mangopay/core/PayInApiImplTest.java b/src/test/java/com/mangopay/core/PayInApiImplTest.java index c2a3ed8b..7cf91463 100644 --- a/src/test/java/com/mangopay/core/PayInApiImplTest.java +++ b/src/test/java/com/mangopay/core/PayInApiImplTest.java @@ -288,6 +288,12 @@ public void createPreAuthorizedDirect() { List preAuthTransactions = this.api.getCardPreAuthorizationApi().getTransactions(cardPreAuthorization.getId(), new Pagination(1, 1)); + assertFalse(preAuthTransactions.isEmpty()); + for (Transaction t : preAuthTransactions) { + assertNotNull(t.getStatus()); + assertNotEquals(TransactionStatus.NotSpecified, t.getStatus()); + } + assertTrue(!"".equals(createPayIn.getId())); assertEquals(wallet.getId(), createPayIn.getCreditedWalletId()); assertTrue(createPayIn.getPaymentType() == PayInPaymentType.PREAUTHORIZED); diff --git a/src/test/java/com/mangopay/core/UserApiImplTest.java b/src/test/java/com/mangopay/core/UserApiImplTest.java index 3b794b26..eff135fe 100644 --- a/src/test/java/com/mangopay/core/UserApiImplTest.java +++ b/src/test/java/com/mangopay/core/UserApiImplTest.java @@ -636,6 +636,12 @@ public void getTransactions() throws Exception { List transactions = this.api.getUserApi().getTransactions(john.getId(), pagination, new FilterTransactions(), null); + assertFalse(transactions.isEmpty()); + for (Transaction t : transactions) { + assertNotNull(t.getStatus()); + assertNotEquals(TransactionStatus.NotSpecified, t.getStatus()); + } + assertTrue(transactions.size() > 0); assertTrue(transactions.get(0).getType() != null); assertTrue(transactions.get(0).getStatus() != null); @@ -653,6 +659,12 @@ public void getTransactionsAndSortByCreationDate() throws Exception { List transactions = this.api.getUserApi().getTransactions(john.getId(), pagination, new FilterTransactions(), sorting); + assertFalse(transactions.isEmpty()); + for (Transaction t : transactions) { + assertNotNull(t.getStatus()); + assertNotEquals(TransactionStatus.NotSpecified, t.getStatus()); + } + assertNotNull(transactions); assertTrue(transactions.size() > 1); assertTrue(transactions.get(0).getCreationDate() > transactions.get(1).getCreationDate()); diff --git a/src/test/java/com/mangopay/core/WalletApiImplTest.java b/src/test/java/com/mangopay/core/WalletApiImplTest.java index 35dab398..43729127 100644 --- a/src/test/java/com/mangopay/core/WalletApiImplTest.java +++ b/src/test/java/com/mangopay/core/WalletApiImplTest.java @@ -1,6 +1,7 @@ package com.mangopay.core; import com.mangopay.core.enumerations.SortDirection; +import com.mangopay.core.enumerations.TransactionStatus; import com.mangopay.core.enumerations.TransactionType; import com.mangopay.entities.PayIn; import com.mangopay.entities.Transaction; @@ -67,6 +68,12 @@ public void getWalletTransactions() throws Exception { assertTrue(transactions.get(0) instanceof Transaction); assertEquals(transactions.get(0).getAuthorId(), john.getId()); //this.assertEqualInputProps(transactions.get(0), payIn); + + assertFalse(transactions.isEmpty()); + for (Transaction t : transactions) { + assertNotNull(t.getStatus()); + assertNotEquals(TransactionStatus.NotSpecified, t.getStatus()); + } } @Test @@ -89,5 +96,11 @@ public void getWalletTransactionsAndSortByCreationDate() throws Exception { assertNotNull(transactions); assertTrue(transactions.size() > 1); assertTrue(transactions.get(0).getCreationDate() > transactions.get(1).getCreationDate()); + + assertFalse(transactions.isEmpty()); + for (Transaction t : transactions) { + assertNotNull(t.getStatus()); + assertNotEquals(TransactionStatus.NotSpecified, t.getStatus()); + } } } From 2a566d4305ff121d54097ef7b622c676a3c88a93 Mon Sep 17 00:00:00 2001 From: Iulian Masar Date: Fri, 7 Feb 2025 17:47:35 +0200 Subject: [PATCH 2/2] removed Reference param from Refund --- src/main/java/com/mangopay/entities/Refund.java | 11 ----------- src/test/java/com/mangopay/core/BaseTest.java | 1 - 2 files changed, 12 deletions(-) diff --git a/src/main/java/com/mangopay/entities/Refund.java b/src/main/java/com/mangopay/entities/Refund.java index f6d85593..4b444891 100644 --- a/src/main/java/com/mangopay/entities/Refund.java +++ b/src/main/java/com/mangopay/entities/Refund.java @@ -43,9 +43,6 @@ public class Refund extends Transaction { @SerializedName("RefundReason") private RefundReason refundReason; - @SerializedName("Reference") - private String reference; - @SerializedName("StatementDescriptor") private String statementDescriptor; @@ -89,14 +86,6 @@ public void setRefundReason(com.mangopay.core.RefundReason refundReason) { this.refundReason = refundReason; } - public String getReference() { - return reference; - } - - public void setReference(String reference) { - this.reference = reference; - } - public String getStatementDescriptor() { return statementDescriptor; } diff --git a/src/test/java/com/mangopay/core/BaseTest.java b/src/test/java/com/mangopay/core/BaseTest.java index 04e3d97f..5f756cfb 100644 --- a/src/test/java/com/mangopay/core/BaseTest.java +++ b/src/test/java/com/mangopay/core/BaseTest.java @@ -1253,7 +1253,6 @@ protected Refund getNewRefundForPayIn(PayIn payIn) throws Exception { refund.setFees(new Money()); refund.getFees().setAmount(payIn.getFees().getAmount()); refund.getFees().setCurrency(payIn.getFees().getCurrency()); - refund.setReference("Reference"); return this.api.getPayInApi().createRefund(payIn.getId(), refund); }