Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update createRouter.js for node 0.6 #34

Open
wolftankk opened this issue Nov 14, 2011 · 8 comments
Open

Please update createRouter.js for node 0.6 #34

wolftankk opened this issue Nov 14, 2011 · 8 comments

Comments

@wolftankk
Copy link

Error: require.paths is removed. Use node_modules folders, or the NODE_PATH environment variable instead.

@ghost
Copy link

ghost commented Dec 9, 2011

same for me.
It seems it imply updating journey and resourcer.

@allenhartwig
Copy link

It looks like journey has updated their code. Just resourcer now.

@dhendo
Copy link

dhendo commented Dec 15, 2011

I have a fork (https://github.com/dhendo/webservice.js) that is working against 0.6.5

I've made a number of changes, so Marak may or may not want to merge back into his.

Main changes:

  • Drop resourcer. Use revalidor instead (it was only using resourcer.validation anyway)
  • Updated the docs view. Added some jquery to allow expansion etc
  • Allow .pattern and .patterns to define a custom route pattern / pattens in a module method
  • Allow multiple captures in the patters - will be passed through in options._captures to the handling method.

YMMV

@ghost
Copy link

ghost commented Dec 15, 2011

@dhendo : thanks, nice work. Beware that "this.endpoint" is hardcoded in demoModule.js

@Marak
Copy link
Owner

Marak commented Jan 16, 2012

@dhendo - Nice! Would you be interested at all at trying to pull out Journey completely and replace with it https://github.com/flatiron/director/ ?

If not, I might be able to get some time in the next few weeks to do a new version.

@dhendo
Copy link

dhendo commented Jan 16, 2012

Yes, I may give that a shot soon.

I went part-way down that route initially, but then figured out what was going wrong with journey.

@Marak
Copy link
Owner

Marak commented Mar 30, 2012

Mostly got rewrite working with Director

https://github.com/Marak/webservice.js/commits/refactor

@dhendo
Copy link

dhendo commented Mar 30, 2012

Cool... I'll take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants