Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please make disable_warnings=0 turn warnings back on? #229

Open
mentalisttraceur opened this issue Apr 3, 2019 · 1 comment
Open

Please make disable_warnings=0 turn warnings back on? #229

mentalisttraceur opened this issue Apr 3, 2019 · 1 comment

Comments

@mentalisttraceur
Copy link

mentalisttraceur commented Apr 3, 2019

It looks like the code only ever globally turns warnings off, but can never turn them back on again.

I have a situation where I need to follow best-practices and only narrowly silence warnings for a single GET request, which generates spurious and expected warnings, but then expose warnings as normal for all other calls.

So it would be really great if disable_warnings=0 turned all of the warnings back on.

(Currently I'm working around this by just exposing our own custom keywords that adjust the urllib3 warnings and log level at the most narrow granularity possible, but I think it would be better to have this functionality in the library.)

@mentalisttraceur mentalisttraceur changed the title Make disable_warnings=0 to turn warnings back on. Make disable_warnings=0 turn warnings back on. Apr 5, 2019
@mentalisttraceur mentalisttraceur changed the title Make disable_warnings=0 turn warnings back on. Please make disable_warnings=0 turn warnings back on? Apr 16, 2019
@mentalisttraceur
Copy link
Author

I just realized I initially worded the subject line of this issue in a way that could be read as a command or demand.

That was not my intent - I was just trying to be concise - so I have now adjusted it accordingly to reduce the potential for that interpretation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant