You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At present, diff and clean can only be applied to all files at once, i.e. they cannot be applied to individual files.
There are two separate commands fix and fix_all, even though the latter really just applies the former to every .rej file present.
My proposal would be to do the following:
Add an optional flag --all to the fix command, and make the input variable rej_file_path optional (with default value ''). Typer can be used to implement this.
If the flag --all passed, run what is currently fix_all.
Remove fix_all as a separate command.
If --all is not passed, check if rej_file_path == ''. If this is the case, then raise an error. Otherwise, apply the current fix command.
Apply the same logic to diff and clean.
@MarkusSagen if you like these ideas, I can have a go at implementing them myself 😄
The text was updated successfully, but these errors were encountered:
💯 Great suggestion! It was not the ideal flow for implementing this before and I think the proposed change is what it should have been from the beginning
@StephanLoor, if you would like to take a stab at it, that would be much appreciated 😃
My idea is to fix two "issues" at the same time:
diff
andclean
can only be applied to all files at once, i.e. they cannot be applied to individual files.fix
andfix_all
, even though the latter really just applies the former to every .rej file present.My proposal would be to do the following:
--all
to thefix
command, and make the input variablerej_file_path
optional (with default value''
). Typer can be used to implement this.--all
passed, run what is currentlyfix_all
.fix_all
as a separate command.--all
is not passed, check ifrej_file_path == ''
. If this is the case, then raise an error. Otherwise, apply the currentfix
command.diff
andclean
.@MarkusSagen if you like these ideas, I can have a go at implementing them myself 😄
The text was updated successfully, but these errors were encountered: