Missing check for dev dependencies

[harryi3t]

I am using the latest version of electron-packager (14.x) which now uses galactus which internally uses flora-colossus
Since the logic for doing the prune was not there before in electron-packager, I was doing the pruning myself. After bumping to latest electron-packager it started crashing with error Failed to locate module...

After doing some digging, I found this code in Walker~walkDependenciesForModuleInModule

if (!discoveredPath && depType !== DepType.OPTIONAL && depType !== DepType.DEV_OPTIONAL) {

Also, I checked valid values of depType, they were

PROD, DEV, OPTIONAL, DEV_OPTIONAL and ROOT

And for all the dev dependencies that I have, the value of depType was always 1 (DEV) for which there is no check

So, should the condition be the following instead?

if (!discoveredPath && depType !== DepType.DEV && .....) {

For me, the workaround was to stop doing the pruning myself so that discoveredPath would be truthy and it won't go in that conditional block.