Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a limit for texts /person/day #7

Open
Marwan01 opened this issue Mar 16, 2020 · 5 comments
Open

Set a limit for texts /person/day #7

Marwan01 opened this issue Mar 16, 2020 · 5 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Marwan01
Copy link
Owner

Stop people from spamming app and using up credits.
Some people and bots will abuse the number as it scales in users. We need to create a way to prevent that from happening programmatically.

A counter for how many messages are left for each user.
Set a counter that will tell you how many messages are left for that user for that day, and stop him from interacting with twilio servers when threshold is reached.

Alternatives would be calling Twilio and asking them for solution for it
This would be great to talk about worldwide capability as well.

@Marwan01 Marwan01 added the good first issue Good for newcomers label Mar 16, 2020
@Marwan01 Marwan01 added the help wanted Extra attention is needed label Mar 24, 2020
@Marwan01
Copy link
Owner Author

@ajayraj
Copy link
Collaborator

ajayraj commented Mar 24, 2020

Found that in docs as well, working on it!

@ajayraj
Copy link
Collaborator

ajayraj commented Mar 24, 2020

Very heavily linked with Verifications, which we are not using currently in sending/receiving. Checked with them on a few areas I was confused, waiting on a response. Stack overflow seems sparse in saying if using this for rate limiting how we're doing is possible. Waiting on a response, pushed some changes to new branch for rate limit testing.

@Marwan01
Copy link
Owner Author

Awesome work @ajayraj ! You definitely seem on the right track. I looked into this issue a while ago and came across the verification stuff as well, but I avoided it thinking we could implement something within the code to avoid the cost. But that most likely won't stop the cost of incoming sms. Still thought of throwing the idea out there! But please do look into the verification if it seems like the reasonable choice to go with.

@ajayraj
Copy link
Collaborator

ajayraj commented Mar 25, 2020

Thanks! Yeah at this point it seems necessary to use verifications for it, I got an email back just now and I'm going to work on it some more, probably will have to contact them another time though

@Marwan01 Marwan01 assigned VoltK and unassigned ajayraj Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants