Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unsafe checking to test suite #79

Open
benesch opened this issue Nov 11, 2023 · 0 comments
Open

Add unsafe checking to test suite #79

benesch opened this issue Nov 11, 2023 · 0 comments

Comments

@benesch
Copy link
Member

benesch commented Nov 11, 2023

In #74, #75, #76, and #77, @icmccorm worked through some potential memory errors with the unsafe code in this repository that were surfaced by an experimental fork of Miri that can detect borrowing violations in foreign functions: https://github.com/icmccorm/miri

It's still a research prototype, but when it becomes suitable for wider use, or integrated with https://github.com/pnkfelix/krabcake, we should investigate running it automatically in CI. Otherwise we're likely to introduce new memory errors during refactorings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant