From a55c62c5c810c84258afcdac7da1a7019a69b332 Mon Sep 17 00:00:00 2001 From: Renatho De Carli Rosa Date: Tue, 15 Oct 2024 00:29:07 -0300 Subject: [PATCH] Revert "Update z-index hierarchy (#65626)" (#66074) Co-authored-by: renatho Co-authored-by: aaronrobertshaw Co-authored-by: juanfra --- packages/base-styles/_z-index.scss | 8 +++++--- packages/block-library/src/cover/editor.scss | 1 + packages/block-library/src/cover/style.scss | 2 +- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/packages/base-styles/_z-index.scss b/packages/base-styles/_z-index.scss index ff61c5793e787f..77238c6f386084 100644 --- a/packages/base-styles/_z-index.scss +++ b/packages/base-styles/_z-index.scss @@ -31,10 +31,12 @@ $z-layers: ( ".interface-interface-skeleton__header": 30, ".interface-interface-skeleton__content": 20, ".edit-widgets-header": 30, + ".wp-block-cover__inner-container": 1, // InnerBlocks area inside cover image block. ".wp-block-cover.is-placeholder .components-placeholder.is-large": 1, // Cover block resizer component inside a large placeholder. - ".wp-block-cover.has-background-dim::before": 0, // Overlay area inside block cover need to be higher than the video background. - ".wp-block-cover__image-background": -1, // Image background inside cover block. - ".wp-block-cover__video-background": -1, // Video background inside cover block. + ".wp-block-cover.has-background-dim::before": 1, // Overlay area inside block cover need to be higher than the video background. + ".block-library-cover__padding-visualizer": 2, // BoxControl visualizer needs to be +1 higher than .wp-block-cover.has-background-dim::before + ".wp-block-cover__image-background": 0, // Image background inside cover block. + ".wp-block-cover__video-background": 0, // Video background inside cover block. ".wp-block-template-part__placeholder-preview-filter-input": 1, // Fixed position appender: diff --git a/packages/block-library/src/cover/editor.scss b/packages/block-library/src/cover/editor.scss index a72b928b55b970..b92c401311beee 100644 --- a/packages/block-library/src/cover/editor.scss +++ b/packages/block-library/src/cover/editor.scss @@ -42,6 +42,7 @@ // Shown while media is being uploaded .components-spinner { position: absolute; + z-index: z-index(".wp-block-cover__inner-container"); top: 50%; left: 50%; transform: translate(-50%, -50%); // Account for spinner dimensions diff --git a/packages/block-library/src/cover/style.scss b/packages/block-library/src/cover/style.scss index 4b2bee7a665970..41b3acf1833fc0 100644 --- a/packages/block-library/src/cover/style.scss +++ b/packages/block-library/src/cover/style.scss @@ -95,8 +95,8 @@ } .wp-block-cover__inner-container { - position: relative; width: 100%; + z-index: z-index(".wp-block-cover__inner-container"); color: inherit; // Reset the fixed LTR direction at the root of the block in RTL languages. /*rtl:raw: direction: rtl; */