From ef17794eb5e34ac3d3e9306587b787424b820041 Mon Sep 17 00:00:00 2001 From: MaySoMusician Date: Thu, 6 May 2021 05:19:41 +0900 Subject: [PATCH 01/15] Update patch for @chakra-ui/nuxt (apply option to VScrollLock) --- patches/@chakra-ui+nuxt+0.3.1.patch | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/patches/@chakra-ui+nuxt+0.3.1.patch b/patches/@chakra-ui+nuxt+0.3.1.patch index aef1592a..2bf08585 100644 --- a/patches/@chakra-ui+nuxt+0.3.1.patch +++ b/patches/@chakra-ui+nuxt+0.3.1.patch @@ -1,5 +1,5 @@ diff --git a/node_modules/@chakra-ui/nuxt/lib/plugin.js b/node_modules/@chakra-ui/nuxt/lib/plugin.js -index afe037f..35f8e3a 100644 +index afe037f..a5b8897 100644 --- a/node_modules/@chakra-ui/nuxt/lib/plugin.js +++ b/node_modules/@chakra-ui/nuxt/lib/plugin.js @@ -3,6 +3,12 @@ import { createClientDirective } from '@chakra-ui/vue/src/directives' @@ -15,3 +15,14 @@ index afe037f..35f8e3a 100644 Vue.prototype.$chakra = { theme, icons: <%= JSON.stringify(options.icons, null, 2) %> +@@ -17,5 +23,9 @@ if (process.client) { + + // VScrollLock + const VScrollLock = require('v-scroll-lock').default +- Vue.use(VScrollLock) ++ Vue.use(VScrollLock, { ++ bodyScrollOptions: { ++ reserveScrollBarGap: true, ++ } ++ }) + } From 1f29bfbce8f7231f00eeb540bcfe4eb7bb2c5660 Mon Sep 17 00:00:00 2001 From: MaySoMusician Date: Mon, 10 May 2021 02:07:59 +0900 Subject: [PATCH 02/15] Update styles of meet link --- pages/meet.vue | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/pages/meet.vue b/pages/meet.vue index 26f4365f..0bcee302 100644 --- a/pages/meet.vue +++ b/pages/meet.vue @@ -11,7 +11,7 @@ {{ welcomeMessage }} - + @@ -66,6 +34,7 @@ import { isValidAdvertisementItem, AdvertisementItem, } from '@/utils/notion' +import AdvertisementGridItemModal from './AdvertisementGridItemModal.vue' type Data = { items: AdvertisementItem[] @@ -76,7 +45,7 @@ type Data = { type Methods = { viewDetails(index: number): void closeDetails(): void - openAdvertiseLink(item: AdvertisementItem): void + openAdvertiseLink(index: number): void getAdvertiseThumbnail(index: number): string } @@ -86,6 +55,7 @@ type Computed = { } export default Vue.extend({ + components: { AdvertisementGridItemModal }, data() { return { items: [], @@ -121,8 +91,9 @@ export default Vue.extend({ this.showModal = false this.selectedIndex = -1 }, - openAdvertiseLink(item) { - const { link } = item + openAdvertiseLink(index) { + if (index < 0) return '' + const { link } = this.itemsAvailable[index] if (!link) return // this.$gtag.event() @@ -130,6 +101,8 @@ export default Vue.extend({ window.open(link, '_blank', 'noopener,noreferrer') }, getAdvertiseThumbnail(index) { + if (index < 0) return '' + const { thumbnail } = this.itemsAvailable[index] if (!thumbnail) return '' return thumbnail[0].url diff --git a/components/AdvertisementGridItemModal.vue b/components/AdvertisementGridItemModal.vue new file mode 100644 index 00000000..ae607ea9 --- /dev/null +++ b/components/AdvertisementGridItemModal.vue @@ -0,0 +1,107 @@ + + + + + From f67a816f8b9681a7fd43e727d9fd40ebed92dcae Mon Sep 17 00:00:00 2001 From: MaySoMusician Date: Mon, 17 May 2021 22:55:16 +0900 Subject: [PATCH 11/15] Add advertisement placeholder item --- components/AdvertisementGrid.vue | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/components/AdvertisementGrid.vue b/components/AdvertisementGrid.vue index 9797133f..cb757820 100644 --- a/components/AdvertisementGrid.vue +++ b/components/AdvertisementGrid.vue @@ -10,6 +10,13 @@ > + + + + + @@ -40,6 +61,7 @@ type Data = { items: AdvertisementItem[] showModal: boolean selectedIndex: number + showWhatsThis: boolean } type Methods = { @@ -61,6 +83,7 @@ export default Vue.extend({ items: [], showModal: false, selectedIndex: -1, + showWhatsThis: false, } }, async fetch() { From adfbc5f0492d7cf724412b719bb4de4ac095c279 Mon Sep 17 00:00:00 2001 From: MaySoMusician Date: Wed, 19 May 2021 23:43:42 +0900 Subject: [PATCH 12/15] Update advertisement modal text styles --- components/AdvertisementGridItemModal.vue | 36 +++++++++++++++++++---- 1 file changed, 31 insertions(+), 5 deletions(-) diff --git a/components/AdvertisementGridItemModal.vue b/components/AdvertisementGridItemModal.vue index ae607ea9..bb136fe7 100644 --- a/components/AdvertisementGridItemModal.vue +++ b/components/AdvertisementGridItemModal.vue @@ -16,14 +16,23 @@ max-w="512px" /> - - {{ - title - }} + + {{ title }} {{ description }} - {{ author }} + {{ + author + }} ({ max-width: 512px; margin: 0 auto; } + + &Author { + position: relative; + z-index: 0; + + &::before { + content: ''; + position: absolute; + display: inline-block; + height: 1px; + width: 2em; + top: 50%; + right: calc(100% + 0.18rem); + border-bottom: 1px solid #1a202c; + z-index: -1; + } + } } } } From 8438c97571da91d689213198de7a332c1f42b846 Mon Sep 17 00:00:00 2001 From: MaySoMusician Date: Wed, 19 May 2021 23:45:30 +0900 Subject: [PATCH 13/15] Render button as nuxt-link when link is internal --- components/AdvertisementGridItemModal.vue | 48 +++++++++++++++++------ 1 file changed, 37 insertions(+), 11 deletions(-) diff --git a/components/AdvertisementGridItemModal.vue b/components/AdvertisementGridItemModal.vue index bb136fe7..c1debb7e 100644 --- a/components/AdvertisementGridItemModal.vue +++ b/components/AdvertisementGridItemModal.vue @@ -35,15 +35,24 @@ > - 詳細 + @@ -55,7 +64,9 @@