Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the humble trove #2

Open
MayeulC opened this issue Feb 28, 2018 · 5 comments
Open

Add support for the humble trove #2

MayeulC opened this issue Feb 28, 2018 · 5 comments

Comments

@MayeulC
Copy link
Owner

MayeulC commented Feb 28, 2018

It would be nice to download games from the humble trove as well. Unfortunately, that requires an active subscription to develop, as far as I know.

@MayeulC MayeulC added this to the 0.6 milestone Feb 28, 2018
@felisucoibi
Copy link

felisucoibi commented Apr 8, 2018

I was going to suggest this, totally agree, +1 humble trove. Btw thanks for your fork, using it since a few months ago.

@felisucoibi
Copy link

Wating for this feature to download all humble bundle monthly things before canceling my subscrition. Bests

@MayeulC
Copy link
Owner Author

MayeulC commented Jun 3, 2018

@felisucoibi I was planning to have a look at it this month, no promises, though.

As far as I know, the only solution here is to scrape the web page, there is no clean API that I know of.

@MayeulC
Copy link
Owner Author

MayeulC commented Jun 17, 2018

@felisucoibi I didn't have time to make a proper implementation, but I cooked together a proof of concept available at https://github.com/MayeulC/hb-downloader/blob/ed36f45f056fc170f16b9a029de441d931613c3c/trove-poc.py (poc-trove branch) if that can help you.

The script trove-poc.py just prints the URLs, but then you can put them in a file and use wget -i $FILE or something like this. It can be adjusted to download the torrent URLs instead, which may be easier to deal with.

The only mandatory configuration you need is to write your login cookie directly in the file. Currently it doesn't filter by platform; I am unsure of your level, but I can provide some code to do this, it's trivial.

It will eventually be part of the main tool, but I have no clear timeline in mind (it could be really soon or really late).


Notes to self (or volunteers) regarding implementation:

This needs to be exposed to the user somehow. I think I will add a --trove command line switch to display/download items only from the trove. Maybe I could implement it as a special gamekey so that programs reusing the API wouldn't forget about this, but some context might then be lost. Moreover, you don't have the same guarantees of stability with the trove games as you have with your own keys.

That said, making it a special gamekey is probably little work, and should provide the expected functionality. This might add a dependency on lxml, however, which I need to check.

The trove listing should be part of the HumbleApi functions, and conform to the data structures used there.

@felisucoibi
Copy link

felisucoibi commented Jun 18, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants