Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we remove PWFSLSmoke from depends? #34

Open
spencerpease opened this issue Apr 5, 2019 · 0 comments
Open

Can we remove PWFSLSmoke from depends? #34

spencerpease opened this issue Apr 5, 2019 · 0 comments
Labels

Comments

@spencerpease
Copy link
Contributor

There might be valid use cases where someone would want to use the PWFSLSmokePlots package without needing the majority of the PWFSLSmoke functionality. It also seems there is some redundancy and potential confusion about working with both of these packages, in that:

library(PWFSLSmoke)
library(PWFSLSmokePlots)

...

is loading PWFSLSmoke twice. Instead, we could instead import PWFSLSmoke and re-export a select subset of necessary functions in PWFSLSmokePlots. This would reduce redundancy in duplicate loading, and prevent cluttering up the namespace if other PWFSLSmoke functions aren't needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants