From 7b8bb21ab615e09ea16f0a94f3e7301d6999b83f Mon Sep 17 00:00:00 2001 From: Mecoli1219 Date: Tue, 7 May 2024 22:00:02 +0800 Subject: [PATCH] #5085 Remove useless comments Signed-off-by: Mecoli1219 --- flyteplugins/go/tasks/pluginmachinery/core/exec_metadata.go | 2 -- flytepropeller/pkg/apis/flyteworkflow/v1alpha1/nodes.go | 1 - flytepropeller/pkg/compiler/transformers/k8s/node.go | 2 -- .../pkg/controller/nodes/task/k8s/task_exec_context.go | 1 - 4 files changed, 6 deletions(-) diff --git a/flyteplugins/go/tasks/pluginmachinery/core/exec_metadata.go b/flyteplugins/go/tasks/pluginmachinery/core/exec_metadata.go index e6228f8925..3051f6c07a 100644 --- a/flyteplugins/go/tasks/pluginmachinery/core/exec_metadata.go +++ b/flyteplugins/go/tasks/pluginmachinery/core/exec_metadata.go @@ -9,8 +9,6 @@ import ( ) // TaskOverrides interface to expose any overrides that have been set for this task (like resource overrides etc) -// -//go:generate mockery -name TaskOverrides -case underscore type TaskOverrides interface { GetResources() *v1.ResourceRequirements GetExtendedResources() *core.ExtendedResources diff --git a/flytepropeller/pkg/apis/flyteworkflow/v1alpha1/nodes.go b/flytepropeller/pkg/apis/flyteworkflow/v1alpha1/nodes.go index 8f4ac83a7c..96fe6f27f4 100644 --- a/flytepropeller/pkg/apis/flyteworkflow/v1alpha1/nodes.go +++ b/flytepropeller/pkg/apis/flyteworkflow/v1alpha1/nodes.go @@ -117,7 +117,6 @@ func (in *ExtendedResources) DeepCopyInto(out *ExtendedResources) { // Once we figure out the autogenerate story we can replace this } -//go:generate mockery -name ExecutableNode -output=mocks type NodeSpec struct { ID NodeID `json:"id"` Name string `json:"name,omitempty"` diff --git a/flytepropeller/pkg/compiler/transformers/k8s/node.go b/flytepropeller/pkg/compiler/transformers/k8s/node.go index 631a520097..d33accd641 100644 --- a/flytepropeller/pkg/compiler/transformers/k8s/node.go +++ b/flytepropeller/pkg/compiler/transformers/k8s/node.go @@ -1,8 +1,6 @@ package k8s import ( - "context" - "github.com/flyteorg/flyte/flytestdlib/logger" "strings" "github.com/go-test/deep" diff --git a/flytepropeller/pkg/controller/nodes/task/k8s/task_exec_context.go b/flytepropeller/pkg/controller/nodes/task/k8s/task_exec_context.go index d09b212cfe..c8881062df 100644 --- a/flytepropeller/pkg/controller/nodes/task/k8s/task_exec_context.go +++ b/flytepropeller/pkg/controller/nodes/task/k8s/task_exec_context.go @@ -50,7 +50,6 @@ func newTaskExecutionMetadata(tCtx pluginsCore.TaskExecutionMetadata, taskTmpl * var err error secretsMap := make(map[string]string) injectLabels := make(map[string]string) - // TODO: Why it couldn't get anything??? if tCtx.GetOverrides().GetOverrideSecurityContext() != nil { if len(tCtx.GetOverrides().GetOverrideSecurityContext().GetSecrets()) > 0 { secretsMap, err = secrets.MarshalSecretsToMapStrings(tCtx.GetOverrides().GetOverrideSecurityContext().GetSecrets())