Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create tr_EN-US branch and remove 'Medabots' in main tr_EN branch #123

Open
14 tasks
VariantXYZ opened this issue Apr 17, 2022 · 7 comments
Open
14 tasks

Create tr_EN-US branch and remove 'Medabots' in main tr_EN branch #123

VariantXYZ opened this issue Apr 17, 2022 · 7 comments
Labels
enhancement New feature or request

Comments

@VariantXYZ
Copy link
Member

VariantXYZ commented Apr 17, 2022 •
edited
Loading

  • gfx/tilesets/ChapterScreenHeaderFooter.malias.png
  • gfx/tilesets/GBCOnlyErrorScreenTextGraphics.malias.png
  • gfx/tilesets/MenuMedawatchGraphics.malias.png
  • gfx/tilesets/MenuMedawatchTextSprites.malias.png
  • gfx/tilesets/OpeningAnimationCharacterNames.malias.png (also RoboRobo Gang)
  • Start Screen animation
  • When playing as other NPCs (Arika -> Erika)
  • gfx/tilesets/Tileset39C7.malias.png + gfx/tilesets/Tileset39C9.malias.png (Robattle transition)
  • Text replacement support
  • gfx/tilesets/patch/MedalScreen.1bpp.png
  • gfx/tilesets/patch/MedarotsScreen.1bpp.png
  • gfx/tilesets/patch/MenuMainGame.1bpp.png
  • gfx/tilesets/patch/RobattleSelection.1bpp.png
  • gfx/tilesets/BorderTextMedarot3.malias.png
@VariantXYZ VariantXYZ added the enhancement New feature or request label Apr 16, 2023
@VariantXYZ
Copy link
Member Author

VariantXYZ commented Jun 11, 2023 •
edited
Loading

It's also in the 'GBC-only' error screen.

@Blaziken257 Blaziken257 mentioned this issue Aug 10, 2023
Closed
@VariantXYZ
Copy link
Member Author

Wasn't meant to close this issue.

@VariantXYZ VariantXYZ reopened this Aug 10, 2023
@VariantXYZ
Copy link
Member Author

Also in the main menu (#206)

VariantXYZ added a commit that referenced this issue Aug 12, 2023
@VariantXYZ
Medabots -> Medarots, reference #123
13e46b7
VariantXYZ added a commit that referenced this issue Aug 12, 2023
@VariantXYZ
Revert "Medabots -> Medarots, reference #123"
a17625b 
This reverts commit 13e46b7.
VariantXYZ added a commit that referenced this issue Aug 12, 2023
@VariantXYZ
Medarot -> Medabots in GBC-only error screen, reference #123
8ecdb55
@Blaziken257
Copy link
Contributor

Some graphics would need to be reworked for the tr_EN-US branch:

bgb01526_2x

bgb02384_2x

@VariantXYZ
Copy link
Member Author

Also need to consider when playing as other NPCs the name may change (specifically Arika -> Erika)

@Blaziken257
Copy link
Contributor

Blaziken257 commented Apr 6, 2024 •
edited
Loading

"Robattle" shows up frequently in the main tr_EN branch too, but it should be meant for the tr_EN-US branch, while "Robottle" should be for tr_EN. There aren't any instances of "Robottle" in the spreadsheet.

This also extends to forms of the word "robattle", such as "robattling" and possibly others.
20240405_075901

@VariantXYZ
Copy link
Member Author

For the sake of having the correct text in the CSV files, it's best to just modify the dump_xlsx stages or add an additional step for text replacement in the CSV files:

# TRANSLATION_SHEET="~/sheet.xlsx" make dump_xlsx
.PHONY: dump_xlsx_dialog dump_xlsx_ptrlist dump_xlsx_glossary dump_xlsx_soundeffects
dump_xlsx: dump_xlsx_dialog dump_xlsx_ptrlist dump_xlsx_glossary dump_xlsx_soundeffects

dump_xlsx_dialog: $(DIALOG_TEXT)
	$(PYTHON) $(SCRIPT)/xlsx2dialog.py "$(TRANSLATION_SHEET)" "$(DIALOG_TEXT)" $(DIALOG)

dump_xlsx_ptrlist: $(PTRLISTS_TEXT)
	$(PYTHON) $(SCRIPT)/xlsx2ptrlist.py "$(TRANSLATION_SHEET)" "$(PTRLISTS_TEXT)" $(PTRLISTS)

dump_xlsx_glossary: $(SCRIPT_RES)
	$(PYTHON) $(SCRIPT)/xlsx2csv.py "$(TRANSLATION_SHEET)" "$(SCRIPT_RES)/glossary.csv" Glossary

dump_xlsx_soundeffects: $(SCRIPT_RES)
	$(PYTHON) $(SCRIPT)/xlsx2csv.py "$(TRANSLATION_SHEET)" "$(SCRIPT_RES)/sound_effects.txt" SoundEffects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Blaziken257 @VariantXYZ