Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Controller metadata anonymous property #643

Open
Gudahtt opened this issue Nov 25, 2021 · 1 comment
Open

Rename Controller metadata anonymous property #643

Gudahtt opened this issue Nov 25, 2021 · 1 comment
Labels

Comments

@Gudahtt
Copy link
Member

Gudahtt commented Nov 25, 2021

The anonymous property of the Base Controller v2 metadata state is meant to indicate whether the state is already anonymized or not, or if it's a function, it's meant as an anonymizing function.

This property is often misinterpreted to mean the opposite of what it's intended to mean though. People have thought anonymous: true means that the data should be anonymized, rather than indicating that it has already been anonymized.

To clarify the meaning, this should be renamed to something easier to understand. Maybe anonymized?

@Gudahtt Gudahtt added the enhancement New feature or request label Nov 25, 2021
@Gudahtt
Copy link
Member Author

Gudahtt commented Sep 22, 2023

On second thought, it seems clearer to name this according to how we plan to use it: to add diagnostic information.

There are a few cases where we want to exclude data because it's too large, and the easiest way to do that would be with this metadata property. Seems wrong to imply it has PII just because we don't want it captured.

@mcmire mcmire changed the title Rename Controller metadata anonoymous property Rename Controller metadata anonymous property Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants