Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Design quality]: Update the mobile header to the design system header - Token details #11854

Open
brianacnguyen opened this issue Oct 17, 2024 · 0 comments · May be fixed by #11855
Open

[Design quality]: Update the mobile header to the design system header - Token details #11854

brianacnguyen opened this issue Oct 17, 2024 · 0 comments · May be fixed by #11855
Assignees
@brianacnguyen
Labels
area-design Design bug (previously known as papercuts - ask Hilary for more detail) regression-prod-11.16.15 Regression bug that was found in production in release 11.16.15 Sev3-low A possible confusion or deception that is only hypothetical & has no known instances in the wild team-design-system All issues relating to design system in Mobile type-bug Something isn't working

Comments

@brianacnguyen
Copy link
Contributor

brianacnguyen commented Oct 17, 2024 •
edited
Loading

Describe the bug

In mobile, the header we have is deprecated across many pages. Updating all headers to the version we have in our design system creates a consistent look and feel.

Expected behavior

Headers for all pages use the DS version, namely:

  • Token Details

Screenshots/Recordings

Screenshot 2024-10-18 at 12 56 18 AM

Figma link

Steps to reproduce

  1. Open MetaMask
  2. Click on Token details

Error messages or log output

No response

Detection stage

In production (default)

Version

11.16.15

Build type

None

Device

Samsung

Operating system

Android

Additional context

Ping @amandaye0h for context

Severity

No response
@brianacnguyen brianacnguyen added area-design Design bug (previously known as papercuts - ask Hilary for more detail) regression-prod-11.16.15 Regression bug that was found in production in release 11.16.15 Sev3-low A possible confusion or deception that is only hypothetical & has no known instances in the wild team-design-system All issues relating to design system in Mobile type-bug Something isn't working labels Oct 17, 2024
@brianacnguyen brianacnguyen changed the title Copy of [Design quality]: Update the mobile header to the design system header [Design quality]: Update the mobile header to the design system header - Token details Oct 17, 2024
@brianacnguyen brianacnguyen linked a pull request Oct 17, 2024 that will close this issue
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brianacnguyen brianacnguyen

Labels
area-design Design bug (previously known as papercuts - ask Hilary for more detail) regression-prod-11.16.15 Regression bug that was found in production in release 11.16.15 Sev3-low A possible confusion or deception that is only hypothetical & has no known instances in the wild team-design-system All issues relating to design system in Mobile type-bug Something isn't working
Projects
Bugs by severity
Status: To be fixed
Bugs by team
Status: To be fixed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: refactor header for tokens MetaMask/metamask-mobile
2 participants
@brianacnguyen @gambinish