Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove using findOne leads to inconsistent state #190

Open
damonmaria opened this issue Dec 16, 2016 · 2 comments · Fixed by #209
Open

Remove using findOne leads to inconsistent state #190

damonmaria opened this issue Dec 16, 2016 · 2 comments · Fixed by #209

Comments

@damonmaria
Copy link

damonmaria commented Dec 16, 2016 •
edited
Loading

remove uses findOne to find the document to remove from localforage. This means that if the selector matches multiple documents then only one is removed from localforage, but all are removed from the Collection.

Also, that only one would be removed is inconsistent and non-obvious. Can all documents matching the selector be removed?
@brucejo75
Copy link
Contributor

This seem like a bug, the fix is simple. I have a PR coming.

@brucejo75 brucejo75 mentioned this issue May 28, 2019
Merged
@brucejo75
Copy link
Contributor

PR #209

@StorytellerCZ StorytellerCZ linked a pull request Jun 17, 2024 that will close this issue
remove method handle multiple doc removes #209
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove method handle multiple doc removes brucejo75/db
2 participants
@damonmaria @brucejo75