Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support specific configuration repositories in Automator #11

Open
sduenas opened this issue Mar 27, 2014 · 3 comments
Open

Support specific configuration repositories in Automator #11

sduenas opened this issue Mar 27, 2014 · 3 comments

Comments

@sduenas
Copy link
Member

sduenas commented Mar 27, 2014

In Automator, all the repositories from a datasource (SCM, MLS, etc) share the same run configuration, but sometimes you need to run some of the repositories with a different one.

For instance, I havie set of repositories to analyze but in one of them, I only want the analysis of some of its directories.

git://xenbits.xen.org/xen.git
git://xenbits.xen.org/osstest.git
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git - arch/*/xen arch/*/include/asm/xen drivers/xen drivers/*/*xen* include/xen arch/*/pci/*xen*

Automator should support this feature.

@dicortazar
Copy link
Member

From my perspective, Automator is a tool to launch other tools in a given order. In addition, this also provide specific information to run each of the tools.

For instance, in order to run GrimoireLib, it's necessary to know the type of analysis that we want to carry out (basic, companies, repositories, etc). Or in the case of Bicho, this needs to know what type of tracker is going to be downloaded.

Having this in mind, I see the analysis of specific directories in the Linux Kernel as another filter applied to the CVSAnalY database: modules. In the same way that we specify in the customers of the GrimoireLib library that they should calculate results for companies or repositories, we should add those filters for directories.

So, not sure if the best approach is to add the filters in the configuration file (the one I guess you propose) or in the customers of the GrimoireLib library, but for sure we should use the same approach in all of the cases. So, if we're going to specify the directories that we're going to analyze in the configuration file, then we should add also the companies, and repositories and even people that we want to analyze. If not, the other way around is to adapt the specific customer of the GrimoireLib library and write down those filters, in the same that we sometimes filter bots from top committers. A third option is to have a specific and new class, that inherits from the SCM class with specific filters needed for this analysis (some companies, some directories, etc). (The latter is probably my proposal in this case).

Thus, summarizing: I'd say that this is an issue report for GrimoireLib more than for Automator :).

My two cents...

@sduenas
Copy link
Member Author

sduenas commented Mar 27, 2014

I understand your point of view but how will you set that this filter is only applied on one of the repositories that my database has? You will need to put the configuration somewhere.

@dicortazar
Copy link
Member

That also makes sense, but then, we should use one approach or the other (probably having a mix of all of them is going to be tricky in the long term). So, if we're moving some filters such as directories to analyze, we should also move the rest of the variables to the config file. Among others: bots, closed conditions and other filters that are specific of each project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants