Project 4 Feedback

[esin87]

Project 4 Feedback

Code Quality - Performing

Criteria: Is the code well-formatted? Are variable and function names semantic and sensible? Is the code easy to read and understand?

Strengths:

• Code is well-formatted with semantic and sensible variable/function/component naming throughout.
• Code is easy to read and understand.
• Code is organized in a rational way, both in terms of individual files and overall directory organization.
• Way to use async/await and try/catch syntax.

Areas for Growth:

• There are a couple instances of console.logs in your code (NewTaskScreen and WelcomeScreen). These should be removed from deployed code. Instead of simply logging the results of errors, how can you implement some user-facing feedback?

Technical Requirements - Excelling

Criteria: How does the project stack up to the requirements for this project? Is the developer making use of the material we've covered in a way that makes sense?

Strengths:

• The project meets all the technical requirements set out for this assignment and demonstrates your ability to learn new technologies quickly.
• Super impressed by how you tackled not only the tasks of project planning and coding, but also learning the logistics of mobile development, React Native, and Async Storage in such a short sprint.
• Love the function you wrote to save tasks and generate IDs for tasks.
• Extensive history of Git commits in frontend repo. Great job working on a development branch and merging changes. For further feature development and for future projects, definitely continue to make use of Git Branches to work on code without affecting the master branch -- this will keep you from having to worry about breaking the working code, and is a useful development practice to get in the habit of doing.

Areas for Growth:

• A really cool next step could be to refactor the logic for storing tasks by their IDs with a Hash Table data structure. This would be an amazing way to implement some of the computer science material we've been learning, and a really great blog topic to show off your programming skillz.
• Adding testing coverage would be a great next technical feature to implement! Here are the docs.
• Work on both the consistency of your commit message formatting as well as their content. Commit messages should be concise, descriptive , and consistently structured -- 'tweaks on iphone screen' is not ideal, though we're all guilty of having messages like that at one point or another. The standard is usually 'present-tense verb + description of what was done' for each and every commit. For example, 'Add styling to tasks container' or 'Refactor API call'.

Creativity and Interface - Excelling

Criteria: Is the application easy to navigate? Does it work well in every major browser? Is it responsive? Does it incorporate modern UI Themes?

Strengths:

• Application is easy to use and navigate. Calls to action are clear, and UI is uncluttered and lends itself well to usability.
• Polished and appealing design. Your applications always have such a pleasing, creative UI.
• So many great touches, like custom icons and the date picker. Scroll and swipe are amazing.

Areas for Growth

• None at this time :)

Functionality - Performing

Criteria: Does the application work without errors or bugs? Does it present a complete app, where every feature is fully implemented in a way that makes sense?

Strengths:

• Application works without errors or bugs observed in the demonstration, and presents a complete application.
• No unfinished or buggy features appear in your application. Nice work focusing on MVP, paring down features when necessary, and executing a complete product flawlessly.

Areas for Growth:

• Would love to see some user-facing error handling instead of logging errors, as mentioned above.
• I know you have a lot more functionality you want to implement for your next features, such as push notifications. The application you have is such a great start, and can't wait to see how you keep building out the functionality.

Presentation - Performing

Criteria: Is there adequate documentation? Is the repository well-organized and free of clutter?

Strengths:

• Repo is well-organized and free of clutter.
• README is comprehensive and engaging documentation, and includes: description, link to deployed app, user stories, technologies used, component hierarchy, wireframes, screenshots, contrib guidelines and installation instructions.
• Nice job filling out the About section with a description of our app, link to deployed version, and tags.

Areas for Growth:

• Getting started/ Installation are probably the same topic.
• In the About section, add tags for the technologies used.

Hard Requirements - Complete:

Your project must:

• Be a complete product.
• Implement thoughtful user stories
• Be deployed online
• Use something we didn't teach in class (React Native, mobile dev)

Checklist:

• Add the deployed URL to repo settings
• Add a readme with:
  • An embedded screenshot of the app ✅
  • Explanations of the technologies used ✅
  • Installation instructions for any dependencies ✅
  • Link to your user stories – who are your users, what do they want and why? ✅
  • Link to your wireframes – sketches of major views / interfaces in your application ✅
  • Descriptions of any unsolved problems or major hurdles you had to overcome ❌ -- a quick fix

Grade: Pass 🎉🎉🎉

Marj, I'm so impressed with what you were able to accomplish for your final project in a week-long sprint. The app that you created speaks to your courage, tenacity and ingenuity as a developer. The fact that it's a passion project on top of everything else suggests to me that you'll continue working on this and building it out to the functionality you originally envisioned, which will help you learn so much more about all the technologies around mobile dev. I hope to see this in the App Store one day soon! Congrats on all you've achieved with this project and throughout the course, and on graduating SEIR. Can't wait to see what you do next!