Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 breaks mra_rom_check.sh #28

Open
MAME-GETTER opened this issue Apr 29, 2020 · 3 comments
Open

Python 3 breaks mra_rom_check.sh #28

MAME-GETTER opened this issue Apr 29, 2020 · 3 comments

Comments

@MAME-GETTER
Copy link

MAME-GETTER commented Apr 29, 2020

Screenshot from 2020-04-29 13-15-40

You cannot mix tabs and spaces, according the PEP8 styleguide:

Spaces are the preferred indentation method.

Tabs should be used solely to remain consistent with code that is already indented with tabs.

Python 3 disallows mixing the use of tabs and spaces for indentation.

Python 2 code indented with a mixture of tabs and spaces should be converted to using spaces exclusively.

When invoking the Python 2 command line interpreter with the -t option, it issues warnings about code that illegally mixes tabs and spaces. When using -tt these warnings become errors. These options are highly recommended!

@sorgelig
Copy link
Member

sorgelig commented Apr 29, 2020

All python2 scripts must be updated to python3.
Weird, badly supported language, alas..

@bootsector
Copy link

It seems it broke the script that turns fast polling on as well

@tacoguy125
Copy link

tacoguy125 commented May 8, 2020

Maybe this is already known but video_settings_optimal.sh is also broken.
*edit - It is just broken. No python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants