Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finding the Thieves Guild quest tracking is bugged. #230

Open
MeemawHustlin opened this issue Oct 6, 2022 · 4 comments
Open

Finding the Thieves Guild quest tracking is bugged. #230

MeemawHustlin opened this issue Oct 6, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@MeemawHustlin
Copy link
Collaborator

This was a known issue with Valarnin's save file reader (which I think he fixed a while back) that has made its way into the interactive guide version of the file reader. If you finish Finding the Thieves Guild without actually starting it first (wanted poster, then bribe owyn and ask about the gray fox), the game still internally tracks its quest stage correctly despite not counting it as complete on the Accomplishments tab, resulting in the checklist saying the quest is done when the in-game progress does not match.

@MeemawHustlin MeemawHustlin added the bug Something isn't working label Oct 6, 2022
@MichaelEbert
Copy link
Owner

Can you give an example save file that shows different behavior between valarnin's code and mine?

@MeemawHustlin
Copy link
Collaborator Author

GitHub won't let me upload a .ess file so I'll send one over on the Discord server for future testing. It appears valarnin's save reader (I'm using the GitHub Pages version of it) still has the same tracking issue, so I guess I was misremembering that it was fixed. I imagine the solution to this problem is to have the save file reader check this quest to make sure at least stage 30 or 40 is in the quest journal in addition to stage 100 since either of those journal entries existing guarantees the quest will count as completed when set to stage 100.

@MeemawHustlin
Copy link
Collaborator Author

Valarnin says the save reader does track this exception by formatting the quest yellow (I missed this because all I was looking for was the checkmark) but it still checks the quest off. The save file reader sees it should be considered incomplete, but probably is still sending the wrong info since the quest is still checked off, which would be why the guide also checks it off anyway.

@MeemawHustlin
Copy link
Collaborator Author

Additional thought on top of this, since fame is linked to specific quests, I need to check if dragging a save file in that has failed to get fame for a quest will still check it off as though it has.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants