Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conceptual documentation: readability of the code #99

Closed
baywet opened this issue Jun 20, 2024 · 3 comments · Fixed by #100
Closed

conceptual documentation: readability of the code #99

baywet opened this issue Jun 20, 2024 · 3 comments · Fixed by #100

Comments

@baywet
Copy link
Member

baywet commented Jun 20, 2024

We should make a clear statement in the documentation on whether the code kiota generates is meant to be readable by humans or not. And the general philosophy behind it.

@maisarissi to make a decision on the topic before we make changes either way.

@sebastienlevert
Copy link
Contributor

I provided my thoughts on the original issue microsoft/kiota#4796 (comment) but I'll quote it also.

Regarding the topic of readability. While we will always try to make it as readable as possible, there will always be cases where machine-generated code will need to take a path that impacts the readability of the code in favor of better generation. There are areas where the code is pretty much very readable, where it's a bit less because of the constraints. I don't think we should be peeking into the generated code and we should leave it as is. I see this code to be as opaque as can be while offering really easy debugging and learning experience.

So my stance: We should not tax any of our development efforts to make the code "more readable" at the expense of complex solutions.

@baywet
Copy link
Member Author

baywet commented Jun 20, 2024

This is the docs page... go put a PR together now :D

@sebastienlevert
Copy link
Contributor

Thanks for pushing @baywet... Thanks for pushing 😂

@github-project-automation github-project-automation bot moved this from Needs Triage 🔍 to Done ✔️ in Kiota Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants