Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive design #7

Open
MikeNGarrett opened this issue Nov 11, 2013 · 12 comments
Open

Responsive design #7

MikeNGarrett opened this issue Nov 11, 2013 · 12 comments

Comments

@MikeNGarrett
Copy link
Owner

Most of the responsiveness is handled already. We need a mobile-friendly menu, a couple breakpoint changes (what if we get rid of the table markup for smaller screens?) and some QA on various devices.

@twerptwo
Copy link

Can we please use the SCSS version of bones? It's much easier to work with than plain old CSS.

@MikeNGarrett
Copy link
Owner Author

I picked css because it's more universal to work with when you have people from a variety of different backgrounds. I can't justify working with a preprocessor in this case even though that's the way I prefer to work.

@twerptwo
Copy link

What are the odds of someone willing to do all this work but won't put up with a preprocessor?

@MikeNGarrett
Copy link
Owner Author

Odds are high as I'm the one that's willing to do the work and not willing to put up with a preprocessor.

Look, I really appreciate the argument you're making, but the barrier of entry to contribute to this project has to be as low as possible.

If you would like to use sass or scss please feel free to do so and upload the css or create a branch where these files exist. Just realize that someone may come along that doesn't know any better and overwrite the css and cause a lot of headaches.

@abelq
Copy link
Collaborator

abelq commented Nov 25, 2013

hi Mike,
Is someone working on making the menu responsive? I could pitch in.

@MikeNGarrett
Copy link
Owner Author

No one is doing it yet. Definitely needs to be done. Your help would be greatly appreciated.

I would love to see something like this: http://responsive-nav.com/ as far as functionality. It doesn't have to use that plugin, though.

@kjpro27
Copy link
Contributor

kjpro27 commented Nov 25, 2013

I'll try take a look tonight.

On Mon, Nov 25, 2013 at 1:46 PM, Mike Garrett [email protected]:

No one is doing it yet. Definitely needs to be done. Your help would be
greatly appreciated.

I would love to see something like this: http://responsive-nav.com/ as
far as functionality. It doesn't have to use that plugin, though.


Reply to this email directly or view it on GitHubhttps://github.com//issues/7#issuecomment-29229541
.

@MikeNGarrett
Copy link
Owner Author

@kjpro27 can you work with @abelq and see what needs to be done?

@kjpro27
Copy link
Contributor

kjpro27 commented Nov 26, 2013

Yeah, I'm looking into it now.

Sent from my iPad

On Nov 25, 2013, at 9:30 PM, Mike Garrett [email protected] wrote:

@kjpro27 can you work with @abelq and see what needs to be done?


Reply to this email directly or view it on GitHub.

@wass3r
Copy link
Collaborator

wass3r commented Nov 26, 2013

@kjpro27 submitted #34 and I merged. Anything else needed for this issue? Also, thanks @kjpro27 !

@wass3r
Copy link
Collaborator

wass3r commented Nov 26, 2013

It might need some styling love, but that could be a separate ticket? (I only see a hyperlink when I hit that breakpoint)

@kjpro27
Copy link
Contributor

kjpro27 commented Nov 26, 2013

Yeah, I wasn't sure if we wanted to make a hamburger button or something a little nicer looking so I just left it at the default for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants