Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting ready for 0.4.4, outstanding issues #222

Closed
sezero opened this issue Nov 5, 2020 · 4 comments
Closed

Getting ready for 0.4.4, outstanding issues #222

sezero opened this issue Nov 5, 2020 · 4 comments

Comments

@sezero
Copy link
Contributor

sezero commented Nov 5, 2020

I think we should make a new 0.4.4 (and a 0.3.16) maintenance release.

Long-standing issues that need solving. E.g.:

And maybe this one (not really sure):

I don't know how fixable they are in a short time (unless @chrisisonwildcode
takes action), so I think that we can still make a v0.4.4 release and change
milestone for the above to 0.4.5. What do you think?

@sezero
Copy link
Contributor Author

sezero commented Nov 7, 2020

BTW, these are the list of changes since previous release:

@mcejp
Copy link
Contributor

mcejp commented Nov 22, 2020

Re #214: could we also have something like

target_include_directories(libwildmidi_static INTERFACE $<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/include>)

so that projects pulling in Wildmidi via add_subdirectory + target_link_libraries get the include path wired up auto-magically? (I could work on this)

@sezero
Copy link
Contributor Author

sezero commented Nov 22, 2020

Re #214: could we also have something like

target_include_directories(libwildmidi_static INTERFACE $<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/include>)

so that projects pulling in Wildmidi via add_subdirectory + target_link_libraries get the include path wired up auto-magically? (I could work on this)

Send a patch or issue a pull request here. Make sure the change is supported by cmake-3.1 (which is the current cmake requirement.)

@sezero
Copy link
Contributor Author

sezero commented Mar 21, 2021

Released 0.4.4 (and 0.3.16). Closing.

@sezero sezero closed this as completed Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants