Skip to content
This repository has been archived by the owner on May 30, 2022. It is now read-only.

Allowing the use of tokio's AsyncBufRead #10

Open
garma83 opened this issue May 11, 2022 · 1 comment
Open

Allowing the use of tokio's AsyncBufRead #10

garma83 opened this issue May 11, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@garma83
Copy link

garma83 commented May 11, 2022

Supporting async buffer streams is a major missing feature I think. In the past there has been quite a bit of discussion about it and it looks even like it has mostly been finished. It might even just be waiting for a merge. Would be great if this can be rescued

tafia/quick-xml#314

@Mingun
Copy link
Owner

Mingun commented May 12, 2022

PR is welcome! As noticed in the tafia/quick-xml#314, I would prefer to reuse a existing code rather than duplicate it -- or using macros, or introduce a new traits / methods in the existing traits.

Also, it seems there are more than one implementation of async readers -- at least async-std also wide used. Reducing duplication in the code would help to support it as well.

The dependence on tokio looks a little overkill -- it's a pretty big crate. Is it possible to depend on the crate, which provides only a trait (is that crate exists)?

@Mingun Mingun added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels May 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants