Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Licensing #131

Open
brianbancroft opened this issue Oct 8, 2024 · 8 comments
Open

Licensing #131

brianbancroft opened this issue Oct 8, 2024 · 8 comments
Assignees
Labels
Docs-A Critical

Comments

@brianbancroft
Copy link
Collaborator

In MKE-Dashboard, the licensing page will point to a licensing docs page for more information and one does not exist yet.

What is needed

@KoryKessel-Mirantis KoryKessel-Mirantis changed the title Licensing and MKE 4 Licensing Oct 10, 2024
@KoryKessel-Mirantis KoryKessel-Mirantis added the Docs-A Critical label Oct 10, 2024
@byDimasik
Copy link
Collaborator

License can be set either via config file or UI.

Config

The config way is straightforward

  1. Set the license token under spec.license.token
spec:
  license:
    token: <your-license-token>
  1. Run mkectl apply

To check the license status, users can see the status of the mkeconfig resource

kubectl -n mke get mkeconfig mke -ojsonpath="{.status.licenseStatus}" | jq 

Example output

{
  "expiration": "2027-10-10T07:00:00Z",
  "licenseType": "Offline",
  "maxEngines": 10,
  "scanningEnabled": true,
  "subject": "sf|0014W0000341gYFQAY|a2X4W000000ZeatUAC",
  "tier": "Production"
}

UI

UI should be almost identical to what we have in MKE 3 docs

Just the upload button is named differently and in addition to uploading a file we allowed pasting the token as a string into a text box. @brianbancroft do you have a screenshot of the most recent version of the license page

@brianbancroft
Copy link
Collaborator Author

brianbancroft commented Oct 25, 2024

@byDimasik I'm not asking for a technical solution. This help page is meant as a first step towards an administrative solution.

This is where a user would likely access the page from: Image

@rachaelbrownie
Copy link
Collaborator

rachaelbrownie commented Oct 25, 2024

That said, the "learn more" in the screenshot above could be good to go to a page with the content that you have written here (so long as we update the text next to the link to not be misleading, as Brian said) @byDimasik, but then to address the concern Brian has raised for this specific issue, we should also need some place to direct users to that describes how to purchase/renew a license; whether thats a page, a phone number, email etc).

We could have two separate pages or one page. either way, but we need both. And they should link to each other if they are separate.

There is also a link in the License Banner to "purchase a license" and it would need to go directly to somewhere they can purchase/renew or learn how to purchase/renew as well.

@rachaelbrownie
Copy link
Collaborator

rachaelbrownie commented Oct 25, 2024

Moreover, once they are on the page for adding a License, documentation on how to get there or how to update it by CLI probably isn't that helpful 😅 . So it's good to have, but yeah, not specifically what we are looking for here.

@brianbancroft
Copy link
Collaborator Author

brianbancroft commented Oct 28, 2024

Image

here is a cleaned, clear screenshot on the page used to add a license as well.

MagdaDziadosz added a commit that referenced this issue Nov 7, 2024
MagdaDziadosz added a commit that referenced this issue Nov 7, 2024
@brianbancroft
Copy link
Collaborator Author

Still noticing that the obtain-license.md has plenty on how to use a license. Will there be instructions on how to obtain a license? https://github.com/Mirantis/mke-docs/blob/32044c349da238aadd7910716bd4cf7beecbf0b2/content/docs/getting-started/obtain-license.md

@MagdaDziadosz
Copy link
Contributor

I used the sources and examples provided in this issue to create this document. The name and most of the content reflects Obtain the license in MKE 3. If you want me to add more on how to obtain a license, I would need some input content for that part. If such content is not available at the moment, will you be open to changing the name to “Licensing” or something similar to be less misleading for the users.

@ry4nz
Copy link
Collaborator

ry4nz commented Nov 8, 2024

@MagdaDziadosz If we’re currently missing details on obtaining a license in MKE 4, what would you recommend the page should include to ensure it’s clear and useful for users? Your insights as both a writer and potential user would be highly valuable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs-A Critical
Projects
None yet
Development

No branches or pull requests

6 participants