-
Notifications
You must be signed in to change notification settings - Fork 62
Plugin error on Nightly 5.99 #106
Comments
Currently I am supporting only 5.1.x branch. Though for this bug (there are many more preventing use on 5.99) I'd ask you if you can paste complete KiCad build (version) info. I think it is connected to the wx version |
This is my KiCad version info Version: (5.99.0-3484-g9efc91c10), release build Libraries: Platform: Linux 5.4.67-1-MANJARO x86_64, 64 bit, Little endian, wxGTK Build Info: Build settings: |
I have dabbled with this a bit. I have noticed that now 'pcbnew' is at the end of title for 5.99 version of KiCad. Thus I have updated the code to
|
Thanks for the info regarding frame name. As for the plugin and 5.99 You'll not be able to fix it. 5.99 changed schematics file format and the plugin is parsing the schematics files. So this is a big task to refactor the plugin. Also the timestamps got replaced with UUIDs So I am postponing it until it is clear if V6 will get eeschema python API or not, as this will have an impact on the schematics file parsing code. Once this is known, I'll start working on the plugins. But the process will be slow as I'll have first to evaluate what kind of architecture suits best for all of my plugins and how should I package the plugins so that they are ready for the promised content (plugin) manager that should also come in V6. |
Actually I hacked together a dirty but working solution yesterday - you can see it in pull request I have just created #115 I understand your point regarding doing proper software engineering, this PR is just a demo of what it takes. |
Just a note on this... The string is now "PCB Editor", not pcbnew. |
BOARD.GetModules() has been changed to GetFootprints(). (Line 321 in action_replicate_layout.py) Also in line 226 in replicatelayout.py. |
Dang, I thought I had 5.99_test... |
This may be a bigger problem. What worries me is that the string "PCB Editor" is marked as translatable in the source code. I don't find it in a .po file, though. |
Thanks for the notice. The way to find parent handle always seemed a bit hacky to me. And now with the string becoming translatable I'll have to find another way. I'll have to look at how Qu1ck solves this. If anybody it would be him, finding proper solution |
Replace Layout,Place Layout and Save/Restore Layout run incorrectly on nightly 5.99.
The wrong code is this sentence
_pcbnew_frame = [x for x in wx.GetTopLevelWindows() if x.GetTitle().lower().startswith('pcbnew')][0]
The contents of the error report are “IndexError:list index out of range"
The operation log of Replace Layout is as follows
10-03 15:03:33 replicate_layout.action_replicate_layout 305:Plugin executed on: 'linux' 10-03 15:03:33 replicate_layout.action_replicate_layout 306:Plugin executed with python version: '3.8.5 (default, Sep 5 2020, 10:50:12) \n[GCC 10.2.0]' 10-03 15:03:33 replicate_layout.action_replicate_layout 307:KiCad build version: (5.99.0-3484-g9efc91c10) 10-03 15:03:33 replicate_layout.action_replicate_layout 308:Replicate layout plugin version: 68 started 10-03 15:03:33 replicate_layout.action_replicate_layout 319:wx top level windows: WindowList: [<wx._core.Frame object at 0x7fdce0133f70>, <wx._core.Frame object at 0x7fdce0146040>, <wx._core.Frame object at 0x7fdce01460d0>, <wx._core.Frame object at 0x7fdce0146160>]
The text was updated successfully, but these errors were encountered: