Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix destroyed interactor group cleanup logic in InteractionModeManager.Update() #964

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Fix destroyed interactor group cleanup logic in InteractionModeManager.Update() #964

merged 1 commit into from
Dec 30, 2024

Conversation

whebertML
Copy link
Contributor

Fixes #963

@whebertML whebertML self-assigned this Dec 12, 2024
ghazen-ml
ghazen-ml reviewed Dec 13, 2024
View reviewed changes
Copy link
Contributor

@ghazen-ml ghazen-ml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you able to tests locally for this change? See #960

@whebertML whebertML mentioned this pull request Dec 18, 2024
Closed
@whebertML
Copy link
Contributor Author

Test results for branch feature/XRI3: All passed (256 out of 258 passed, 2 are ignored):

Editor Test Runner:
image

PowerShell:
image

@keveleigh keveleigh merged commit ef298f0 into MixedRealityToolkit:feature/XRI3 Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghazen-ml ghazen-ml ghazen-ml left review comments

@keveleigh keveleigh keveleigh approved these changes

@marlenaklein-msft marlenaklein-msft Awaiting requested review from marlenaklein-msft marlenaklein-msft is a code owner

@AMollis AMollis Awaiting requested review from AMollis AMollis is a code owner

@shaynie shaynie Awaiting requested review from shaynie shaynie is a code owner

Assignees

@whebertML whebertML

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@whebertML @keveleigh @ghazen-ml